From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Oliver Kiddle <okiddle@yahoo.co.uk>
Cc: Andy Spencer <andy@pileus.org>, zsh-workers@zsh.org
Subject: Re: [PATCH] Add completion for cpupower command
Date: Mon, 1 Aug 2016 21:41:09 +0000 [thread overview]
Message-ID: <20160801214109.GD2838@tarsus.local2> (raw)
In-Reply-To: <16722.1470082775@hydra.kiddle.eu>
Oliver Kiddle wrote on Mon, Aug 01, 2016 at 22:19:35 +0200:
> Andy Spencer wrote:
> > + '(-f --freq)'{-f,--freq}'[new frequency for userspace governor]:freq->freq'
>
> There's a colon missing on that line.
Should it be {-f+,--freq=}? That is, can the argument be in the same
word as the option?
The part after the first colon is in this function abbreviated ("freq",
"secs", etc); don't we usually prefer full noun phrases ("frequency",
"interval (seconds)", etc)?
Oliver's review addresses all the other points I noticed (and a few that
I didn't).
Cheers,
Daniel
next prev parent reply other threads:[~2016-08-01 21:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-31 11:05 Andy Spencer
2016-08-01 9:46 ` [PATCH] _cpupower: Move to correct subfolder Andy Spencer
2016-08-01 20:19 ` [PATCH] Add completion for cpupower command Oliver Kiddle
2016-08-01 21:41 ` Daniel Shahaf [this message]
2016-09-21 20:10 ` Oliver Kiddle
2016-08-08 19:31 ` Christian Heinrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160801214109.GD2838@tarsus.local2 \
--to=d.s@daniel.shahaf.name \
--cc=andy@pileus.org \
--cc=okiddle@yahoo.co.uk \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).