From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-38999-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 15703 invoked by alias); 4 Aug 2016 21:54:11 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 38999
Received: (qmail 14743 invoked from network); 4 Aug 2016 21:54:11 -0000
X-Qmail-Scanner-Diagnostics: from hermes.apache.org by f.primenet.com.au (envelope-from <danielsh@apache.org>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1.  
 Clear:RC:0(140.211.11.3):SA:0(-1.3/5.0):. 
 Processed in 0.125505 secs); 04 Aug 2016 21:54:11 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.3 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	RP_MATCHES_RCVD autolearn=unavailable autolearn_force=no version=3.4.1
X-Envelope-From: danielsh@apache.org
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
Received-SPF: none (ns1.primenet.com.au: domain at apache.org does not designate permitted sender hosts)
Date: Thu, 04 Aug 2016 21:47:28 +0000
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [PATCH 3(b)/3] _man: Support _correct_word.
Message-ID: <20160804214728.GA12562@tarsus.local2>
References: <1470326066-3241-1-git-send-email-danielsh@tarsus.local2>
 <1470326066-3241-5-git-send-email-danielsh@tarsus.local2>
 <20160804170809.0f972f07@pwslap01u.europe.root.pri>
 <CAH+w=7ayiaObcLHxZ6m7Ztj4Kzgm3mjvb0JywpCWcHYyJjQSSQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAH+w=7ayiaObcLHxZ6m7Ztj4Kzgm3mjvb0JywpCWcHYyJjQSSQ@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)

Bart Schaefer wrote on Thu, Aug 04, 2016 at 09:28:44 -0700:
> On Thu, Aug 4, 2016 at 9:08 AM, Peter Stephenson
> <p.stephenson@samsung.com> wrote:
> > On Thu, 4 Aug 2016 15:54:26 +0000
> > Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> >> Since compfiles is undocumented, avoid its use altogether, replacing it by
> >> a construct that blackbox analysis suggests to be equivalent.
> >
> > This is likely to be saner, if it works.
> 
> I'll just point out that this proposed change means that _man_pages no
> longer accepts the -M argument to add a matcher spec.

Might you have misread the diff?

Before this patch, -M was handled twice: both by the zparseopts call and
by compadd.  With this patch, -M is only handled by compadd.

Empirically, matchspecs are honoured:

    % zstyle :completion:\* matcher-list ''  "r:|::=* r:|=*"
    % man X::L::Pat<TAB>
    <becomes>
    % man XML::Lib::Pattern

I tried to clarify this in the log message.

Cheers,

Daniel