From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] New :P history modifier.
Date: Thu, 18 Aug 2016 16:55:41 +0000 [thread overview]
Message-ID: <20160818165541.GB25890@tarsus.local2> (raw)
In-Reply-To: <160817100614.ZM21570@torch.brasslantern.com>
Bart Schaefer wrote on Wed, Aug 17, 2016 at 10:06:14 -0700:
> On Aug 17, 4:31pm, Daniel Shahaf wrote:
> }
> } - xsymlink() is not a drop-in replacement: it tolerates trailing
> } non-existing path components. The single callsite in current master
> } wouldn't care, though.
>
> Pretty much my point; if there's only one call and they're equivalent
> for that instance, why leave the special case?
*nod*
> } > The new word modifier ':P' computes the physical path of the argument.
> } > it is different from the existing ':a' modifier which does always
> } > resolves /before/here/../after to /before/after, and differs from the
> } > existing ':A' modifier which resolves symlinks only after here/.. is
> } > removed even when /before/here is itself a symbolic link.
> }
> } What about the "It is recommended [to audit uses of :A and change them
> } to :P]" sentence that the original patch had, should it be kept or
> } removed?
>
> IMO it can be kept.
Kept. The interdiff so far follows.
Thanks again for the review,
Daniel
diff --git a/Completion/Zsh/Type/_history_modifiers b/Completion/Zsh/Type/_history_modifiers
index 5141d80..1a049d6 100644
--- a/Completion/Zsh/Type/_history_modifiers
+++ b/Completion/Zsh/Type/_history_modifiers
@@ -64,8 +64,8 @@ while true; do
)
if (( ! global )); then
list+=(
- "a:absolute path, resolve '..' logically"
- "A:same, then resolve symlinks"
+ "a:absolute path, resolve '..' lexically"
+ "A:as ':a', then resolve symlinks"
"c:PATH search for command"
"g:globally apply s or &"
"h:head - strip trailing path element"
diff --git a/NEWS b/NEWS
index d676e40..65b246d 100644
--- a/NEWS
+++ b/NEWS
@@ -7,13 +7,13 @@ Note also the list of incompatibilities in the README file.
Changes from 5.2 to 5.3
-----------------------
-The new word modifier ':P' computes the realpath() of the argument.
-It is different from the existing ':a' modifier which does not resolve
-symlinks, and from the existing ':A' modifier which always resolves
-/before/here/../after to /before/after --- even if /before/here is
-a symbolic link. It is recommended to review uses of ':A' and, if
-appropriate, convert them to ':P' as soon as compatibility with 5.2 is
-no longer a requirement.
+The new word modifier ':P' computes the physical path of the argument.
+It is different from the existing ':a' modifier which always resolves
+'/before/here/../after' to '/before/after', and differs from the
+existing ':A' modifier which resolves symlinks only after 'here/..' is
+removed, even when /before/here is itself a symbolic link. It is
+recommended to review uses of ':A' and, if appropriate, convert them
+to ':P' as soon as compatibility with 5.2 is no longer a requirement.
Changes from 5.1.1 to 5.2
-------------------------
prev parent reply other threads:[~2016-08-18 16:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 23:54 Daniel Shahaf
2016-08-17 7:02 ` Bart Schaefer
2016-08-17 16:31 ` Daniel Shahaf
2016-08-17 17:06 ` Bart Schaefer
2016-08-18 16:55 ` Daniel Shahaf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160818165541.GB25890@tarsus.local2 \
--to=d.s@daniel.shahaf.name \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).