zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Stefano Balzan <stefano.balzan@gmail.com>
Cc: zsh-workers@zsh.org
Subject: Re: Zsh Completion - Bug report
Date: Sat, 20 Aug 2016 03:07:38 +0000	[thread overview]
Message-ID: <20160820030738.GA15743@fujitsu.shahaf.local2> (raw)
In-Reply-To: <CAEimH9Ad+iraRCTnpFBOzrCv5gf=3cnJ=pspDFCSL1UMNakSbg@mail.gmail.com>

Stefano Balzan wrote on Fri, Aug 19, 2016 at 20:03:50 +0200:
> Thank you, I think your fix should do, pay attention to the typo Axel
> pointed out though.

Pushed with the correction — thanks everyone for the reviews.

> I'm no expert of the 'ip' command, anyway this is how I would add an arp
> entry:
> 
>  "ip neigh add 192.168.1.1 lladdr 12:34:56:78:ab:cd [other parameters]"
> 
> Probably the lladdr keyword (link layer address) should be suggested at
> argv[4], but I'm not completely sure.

Thanks for the example.  Currently, argv[4] in your command is completed
correctly but argv[3] completes as argv[4]; that is: completing argv[3]
offers lladdr and doesn't offer "an IP address".

It's probably not hard to fix, but I'll leave it to someone else...

Cheers,

Daniel


  reply	other threads:[~2016-08-20  3:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-19 10:10 Stefano Balzan
2016-08-19 15:58 ` Daniel Shahaf
2016-08-19 17:26   ` Axel Beckert
2016-08-19 18:03     ` Stefano Balzan
2016-08-20  3:07       ` Daniel Shahaf [this message]
2016-08-19 17:38   ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160820030738.GA15743@fujitsu.shahaf.local2 \
    --to=d.s@daniel.shahaf.name \
    --cc=stefano.balzan@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).