From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-39079-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 539 invoked by alias); 20 Aug 2016 03:07:54 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 39079
Received: (qmail 812 invoked from network); 20 Aug 2016 03:07:54 -0000
X-Qmail-Scanner-Diagnostics: from out2-smtp.messagingengine.com by f.primenet.com.au (envelope-from <d.s@daniel.shahaf.name>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1.  
 Clear:RC:0(66.111.4.26):SA:0(0.0/5.0):. 
 Processed in 0.109144 secs); 20 Aug 2016 03:07:54 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=0.0 required=5.0 tests=T_DKIM_INVALID
	autolearn=unavailable autolearn_force=no version=3.4.1
X-Envelope-From: d.s@daniel.shahaf.name
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=
	daniel.shahaf.name; h=cc:content-transfer-encoding:content-type
	:date:from:in-reply-to:message-id:mime-version:references
	:subject:to:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=lA0WhviLAgAOyO09
	s0k479QcSTQ=; b=E6B1vzH0n86v4bP/8eguIGVekA/j3GjHF1/MLijYDlRp6GsD
	jqFxgZv+S2XDDpYTG7wyQN6pna+YHFLoJRgYKzTSm4js9WqgxR/7KHo6pjZJ4tU7
	bq6Lwp0eol7XxfrxSKm3eQjMfT8tzQFGYmHVVZhzmMbBBhlQ1iBrtRW1+hg=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:content-transfer-encoding:content-type
	:date:from:in-reply-to:message-id:mime-version:references
	:subject:to:x-sasl-enc:x-sasl-enc; s=smtpout; bh=lA0WhviLAgAOyO0
	9s0k479QcSTQ=; b=gkHYrnSJi4mQwRLMCOOr2NwJuB/j8wtRJ8bi7AqNS9Az0iM
	mEsMXZFdbf3k7INO5pQnxmk5kzsLWSD8wtXD6wZLeQ1I4210psc68wfcXayoMhJM
	tn0M7KzRCECTsk/ZMW6wNfxjgO25a9WmjoOdkpRcaZ6Yrx956PdOdl7IajwU=
X-Sasl-enc: dla1RR+y7Ye9cXlIj7WX32EWJJcdLfqV04tG/vCf3j+x 1471662466
Date: Sat, 20 Aug 2016 03:07:38 +0000
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Stefano Balzan <stefano.balzan@gmail.com>
Cc: zsh-workers@zsh.org
Subject: Re: Zsh Completion - Bug report
Message-ID: <20160820030738.GA15743@fujitsu.shahaf.local2>
References: <CAEimH9D2Nu1b7s2EHWkBM1EAtJyREHMMjcFod_1OCXsJD=ke6g@mail.gmail.com>
 <20160819155829.GA3389@fujitsu.shahaf.local2>
 <20160819172605.GG3597@sym.noone.org>
 <CAEimH9Ad+iraRCTnpFBOzrCv5gf=3cnJ=pspDFCSL1UMNakSbg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAEimH9Ad+iraRCTnpFBOzrCv5gf=3cnJ=pspDFCSL1UMNakSbg@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)

Stefano Balzan wrote on Fri, Aug 19, 2016 at 20:03:50 +0200:
> Thank you, I think your fix should do, pay attention to the typo Axel
> pointed out though.

Pushed with the correction — thanks everyone for the reviews.

> I'm no expert of the 'ip' command, anyway this is how I would add an arp
> entry:
> 
>  "ip neigh add 192.168.1.1 lladdr 12:34:56:78:ab:cd [other parameters]"
> 
> Probably the lladdr keyword (link layer address) should be suggested at
> argv[4], but I'm not completely sure.

Thanks for the example.  Currently, argv[4] in your command is completed
correctly but argv[3] completes as argv[4]; that is: completing argv[3]
offers lladdr and doesn't offer "an IP address".

It's probably not hard to fix, but I'll leave it to someone else...

Cheers,

Daniel