From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: zsh-workers@zsh.org
Subject: Re: file completion(?) erases word typed
Date: Thu, 25 Aug 2016 01:19:50 +0000 [thread overview]
Message-ID: <20160825011950.GA23717@fujitsu.shahaf.local2> (raw)
In-Reply-To: <160824170454.ZM22771@torch.brasslantern.com>
Bart Schaefer wrote on Wed, Aug 24, 2016 at 17:04:54 -0700:
> On Aug 24, 7:13pm, Daniel Shahaf wrote:
> }
> } > +_path_files:713> compadd -Qf -J -default- -p usr/local/bin/ -s '' -W /usr/local/bin/ -M 'r:|/=* r:|=*' -a tmp1
> } >
> } > I have no idea why ignoring the path minus its leading slash would ever
> } > be correct, but in any case this appears to be adding the full path by
> } > two different and contradictory approaches.
> }
> } What _absolute_command_paths intended to be is:
> }
> } - You can type in an absolute path to an executable file, even if that
> } file is not in $PATH or in $commands.
>
> What's the reason for passing -P / to _path_files in _typed-in_* ?
_typed-in_* must complete only absolute paths. The -P / was an attempt
to disallow non-absolute paths.
Perhaps this would be better? There may be a way to rewrite it without
-P entirely, but that evades me at the moment.
diff --git a/Completion/Unix/Type/_absolute_command_paths b/Completion/Unix/Type/_absolute_command_paths
index e9ab170..f61f04d 100644
--- a/Completion/Unix/Type/_absolute_command_paths
+++ b/Completion/Unix/Type/_absolute_command_paths
@@ -16,7 +18,13 @@ _hashed_absolute_command_paths() {
# This function completes absolute pathnames of executables, e.g., /etc/rc.local
_typed-in_absolute_command_paths() {
# TODO: the description "full path to an executable" and tag in the caller are ignored by _path_files
- _path_files -/ -g '*(-*)' -P / -W /
+ if [[ -z $PREFIX ]]; then
+ _path_files -/ -g '*(-*)' -P / -W /
+ elif [[ $PREFIX[1] == / ]]; then
+ _path_files -/ -g '*(-*)' -W /
+ else
+ return 1
+ fi
}
_absolute_command_paths() {
> That's what's causing the strange -p usr/local/bin getting passed to
> compadd. Despite what the doc says, _path_files doesn't actually pass
> the -P option along to compadd, instead it calls "compset -P" which
> makes it an ignored prefix instead.
>
> I'm still not sure whether (or what) this has to do with the word on
> the line disappearing.
*nod*
next prev parent reply other threads:[~2016-08-25 1:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 22:48 Daniel Shahaf
2016-08-24 5:52 ` Bart Schaefer
2016-08-24 19:13 ` Daniel Shahaf
2016-08-25 0:04 ` Bart Schaefer
2016-08-25 1:19 ` Daniel Shahaf [this message]
2016-08-30 7:03 ` Bart Schaefer
2016-09-14 3:49 ` legend for match_str (was: Re: file completion(?) erases word typed) Daniel Shahaf
2016-09-14 5:25 ` Bart Schaefer
2016-11-17 21:51 ` file completion(?) erases word typed Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160825011950.GA23717@fujitsu.shahaf.local2 \
--to=d.s@daniel.shahaf.name \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).