From: Peter Stephenson <p.stephenson@samsung.com>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [PATCHv2] [bug] $SHLVL decremented for the last command of a subshell
Date: Tue, 30 Aug 2016 14:04:57 +0100 [thread overview]
Message-ID: <20160830140457.74d9d32d@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <20160830124426.GA15615@chaz.gmail.com>
On Tue, 30 Aug 2016 13:44:26 +0100
Stephane Chazelas <stephane.chazelas@gmail.com> wrote:
> 2016-08-29 18:55:05 -0700, Bart Schaefer:
> > On Aug 29, 4:51pm, Stephane Chazelas wrote:
> > }
> > } I think the change below should be enough (also condensed the 2
> > } "if"s below (unrelated)):
> >
> > This looks fine, although I think we generally keep the braces on the
> > "if" body whenever there is more than one line following -- even if
> > some of those lines are comments.
> >
> > Either that or move the comment above the "if".
>
> How about this (factorised the !subsh some more comments and
> added some test cases):
This is probably fine. I've been dithering over cases where for
consistency we might want to decrement SHLVL even in a subshell because
we're exec'ing for some other reason (so would need to do it at the last
minute before exiting if the exec is faked), but I suspect this is too
obscure to be worth special treatment.
pws
next prev parent reply other threads:[~2016-08-30 13:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-22 6:17 Stephane Chazelas
2016-08-29 15:51 ` [PATCH] " Stephane Chazelas
2016-08-30 1:55 ` Bart Schaefer
2016-08-30 12:44 ` [PATCHv2] " Stephane Chazelas
2016-08-30 13:04 ` Peter Stephenson [this message]
2016-08-30 16:46 ` Stephane Chazelas
2016-08-30 17:00 ` Peter Stephenson
2016-08-30 18:34 ` Mikael Magnusson
2016-08-31 9:02 ` Peter Stephenson
2016-08-30 19:54 ` Stephane Chazelas
2016-08-30 20:10 ` Stephane Chazelas
2016-08-31 10:06 ` Peter Stephenson
2016-09-04 5:32 ` Stephane Chazelas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160830140457.74d9d32d@pwslap01u.europe.root.pri \
--to=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).