zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Marko Myllynen <myllynen@redhat.com>
Cc: zsh workers <zsh-workers@zsh.org>
Subject: Re: More _libvirt (virsh) completion tweaks
Date: Tue, 6 Sep 2016 00:16:52 +0000	[thread overview]
Message-ID: <20160906001652.GA30336@fujitsu.shahaf.local2> (raw)
In-Reply-To: <2a9d0f77-a2af-a6aa-93b6-962204258164@redhat.com>

Marko Myllynen wrote on Mon, Sep 05, 2016 at 10:39:16 +0300:
> Most notably, we now complete domains without the --domain option in
> case no other options are provided. I picked up few commands which
> I think are most often used, please feel free to adjust the list of
> commands if you have other commands in mind.

Sure, we can add them as we run across them.

> +++ b/Completion/Unix/Command/_libvirt
> @@ -127,13 +127,13 @@ case $state in
> -    if [[ $words[-2] == --(dir|emulatorbin|file|mountpoint|*path|script|source-dev) || $words[-1] == (/*|.*) ]]; then
> +    if [[ $words[CURRENT-1] == --(dir|emulatorbin|file|mountpoint|*path|script|source-dev) || $words[-1] == (/*|.*) ]]; then

The second disjunct should use $words[CURRENT] rather than $words[-1].
I've amended this and pushed.

Thanks for all the patches1

Daniel


  reply	other threads:[~2016-09-06  0:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-05  7:39 Marko Myllynen
2016-09-06  0:16 ` Daniel Shahaf [this message]
2016-09-06  8:46   ` Marko Myllynen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160906001652.GA30336@fujitsu.shahaf.local2 \
    --to=d.s@daniel.shahaf.name \
    --cc=myllynen@redhat.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).