From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-39222-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 21019 invoked by alias); 7 Sep 2016 13:49:38 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 39222
Received: (qmail 19912 invoked from network); 7 Sep 2016 13:49:38 -0000
X-Qmail-Scanner-Diagnostics: from mailout4.w1.samsung.com by f.primenet.com.au (envelope-from <p.stephenson@samsung.com>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1.  
 Clear:RC:0(210.118.77.14):SA:0(-1.1/5.0):. 
 Processed in 0.46896 secs); 07 Sep 2016 13:49:38 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.1 required=5.0 tests=RP_MATCHES_RCVD
	autolearn=unavailable autolearn_force=no version=3.4.1
X-Envelope-From: p.stephenson@samsung.com
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
Received-SPF: none (ns1.primenet.com.au: domain at samsung.com does not designate permitted sender hosts)
X-AuditID: cbfec7f5-f792e6d0000013f5-a4-57d0188f3bc6
Date: Wed, 07 Sep 2016 14:39:23 +0100
From: Peter Stephenson <p.stephenson@samsung.com>
To: zsh-workers@zsh.org
Subject: Re: [bug] "zmodload -F zsh/system -p:errnos" disables $sysparams
 instead of $errnos
Message-id: <20160907143923.1eec1760@pwslap01u.europe.root.pri>
In-reply-to: <20160907113529.71060cf4@pwslap01u.europe.root.pri>
References: <20160907093918.GB11851@chaz.gmail.com>
 <20160907113529.71060cf4@pwslap01u.europe.root.pri>
Organization: Samsung Cambridge Solution Centre
X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu)
MIME-version: 1.0
Content-type: text/plain; charset=US-ASCII
Content-transfer-encoding: 7bit
X-Brightmail-Tracker:
 H4sIAAAAAAAAA+NgFrrALMWRmVeSWpSXmKPExsVy+t/xq7r9EhfCDS4uYLM42PyQyYHRY9XB
	D0wBjFFcNimpOZllqUX6dglcGQsXvGApaBaouPnwJXsD42+eLkZODgkBE4men89ZIGwxiQv3
	1rN1MXJxCAksZZT48G8CE4Qzg0li4oIJYFVCAqcZJY69DoVInGGUmNfzECzBIqAqcXHrFVYQ
	m03AUGLqptmMILaIgLjE2bXnwWqEBeIkJmxqAavhFbCX2Lx+JZjNKeAgsXHBFXaIBZkSa2/v
	AuvlF9CXuPr3ExPEefYSM6+cYYToFZT4Mfke2ExmAS2JzduaWCFseYnNa94yQ8xRl7hxdzf7
	BEbhWUhaZiFpmYWkZQEj8ypG0dTS5ILipPRcI73ixNzi0rx0veT83E2MkHD+uoNx6TGrQ4wC
	HIxKPLwVu8+FC7EmlhVX5h5ilOBgVhLhjRS8EC7Em5JYWZValB9fVJqTWnyIUZqDRUmcd+au
	9yFCAumJJanZqakFqUUwWSYOTqkGxr65MVPfcUy6lafDW2/IUnxWgO2m0qb0+Ucif8Ycr9lf
	cvjb5jvxWrN7DTSkqr3PCnd2G0jYf14uwmqhlDvt3ZJFtgdLwoOU91xgvlA5qXPvWX7h9Xrv
	qiY57m0uLH8dfmi2f5O8Psdt202X/0kVHtDUsc247+otYvBHb6r/3VZOtk3TDllaKrEUZyQa
	ajEXFScCAGmrgbNjAgAA

On Wed, 7 Sep 2016 11:35:29 +0100
Peter Stephenson <p.stephenson@samsung.com> wrote:
> It looks like this is because math functions were never properly counted
> --- there are very few in modules so no one noticed.  We could do with
> some tests for this.

pws

diff --git a/Test/V01zmodload.ztst b/Test/V01zmodload.ztst
index 349ae9c..092f9d1 100644
--- a/Test/V01zmodload.ztst
+++ b/Test/V01zmodload.ztst
@@ -271,6 +271,80 @@
 0:Listing feature autoloads includes unloaded modules
 >zmodload -Fa zsh/zftp b:zftp
 
+  if ! zmodload zsh/system >/dev/null 2>&1; then
+    ZTST_skip="zsh/system module not available"
+  else
+    zmodload -lF zsh/system
+    zmodload -F zsh/system -p:errnos
+    print ${+errnos}
+    zmodload -lF zsh/system
+    zmodload -F zsh/system +p:errnos
+    print ${+errnos}
+    zmodload -lF zsh/system
+  fi
+0:Regression tests for index bug with math functions.
+>+b:syserror
+>+b:sysread
+>+b:syswrite
+>+b:sysopen
+>+b:sysseek
+>+b:zsystem
+>+f:systell
+>+p:errnos
+>+p:sysparams
+>0
+>+b:syserror
+>+b:sysread
+>+b:syswrite
+>+b:sysopen
+>+b:sysseek
+>+b:zsystem
+>+f:systell
+>-p:errnos
+>+p:sysparams
+>1
+>+b:syserror
+>+b:sysread
+>+b:syswrite
+>+b:sysopen
+>+b:sysseek
+>+b:zsystem
+>+f:systell
+>+p:errnos
+>+p:sysparams
+
+  if ! zmodload zsh/system >/dev/null 2>&1; then
+    ZTST_skip="zsh/system module not available"
+  else
+    zmodload -F zsh/system -f:systell
+    zmodload -lF zsh/system
+    (print $(( systell(-1) )))
+    zmodload -F zsh/system +f:systell
+    zmodload -lF zsh/system
+    (print $(( systell(-1) )))
+  fi
+1:Module Features for math functions
+>+b:syserror
+>+b:sysread
+>+b:syswrite
+>+b:sysopen
+>+b:sysseek
+>+b:zsystem
+>-f:systell
+>+p:errnos
+>+p:sysparams
+>+b:syserror
+>+b:sysread
+>+b:syswrite
+>+b:sysopen
+>+b:sysseek
+>+b:zsystem
+>+f:systell
+>+p:errnos
+>+p:sysparams
+?(eval):6: unknown function: systell
+?(eval):9: file descriptor out of range
+
 %clean
 
  eval "$deps"