From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-39327-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 26128 invoked by alias); 14 Sep 2016 18:47:28 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 39327
Received: (qmail 15955 invoked from network); 14 Sep 2016 18:47:28 -0000
X-Qmail-Scanner-Diagnostics: from mx.spodhuis.org by f.primenet.com.au (envelope-from <zsh-workers+phil.pennock@spodhuis.org>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1.  
 Clear:RC:0(94.142.241.89):SA:0(-2.3/5.0):. 
 Processed in 0.558158 secs); 14 Sep 2016 18:47:28 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.3 required=5.0 tests=RP_MATCHES_RCVD,SPF_PASS,
	T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no
	version=3.4.1
X-Envelope-From: zsh-workers+phil.pennock@spodhuis.org
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
Received-SPF: pass (ns1.primenet.com.au: SPF record at spodhuis.org designates 94.142.241.89 as permitted sender)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=spodhuis.org; s=d201608; h=In-Reply-To:Content-Transfer-Encoding:
	Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date;
	bh=kaxXlFQxshDusagSrXGKqZyPPRqjBtkcwNfyRuElyBk=; b=1OXJYUqxNsIbWa6H0lMsil6eVs
	x4TreRwO0O8FQgwtw6OXd2VF40rmFfuJHyY10uyNU7E4jinlySsGXmd4OMWiC93FDSif6H/WSS9Dx
	AaXl8KFv+Wzu291eTJLBbV/lviQe+Y5YQXMla3ZLqsUjp30l2f+rIZ/bojlccyqC+3y5S0nV6y8IK
	PW8L3URywawglrl4sAn33GO8AZAZ;
Date: Wed, 14 Sep 2016 18:47:17 +0000
From: Phil Pennock <zsh-workers+phil.pennock@spodhuis.org>
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: zsh-workers@zsh.org
Subject: Re: zsh/re2 : avoid until further notice
Message-ID: <20160914184717.GA9187@tower.spodhuis.org>
References: <20160908041556.GA8401@breadbox.private.spodhuis.org>
 <20160908144203.GA28545@fujitsu.shahaf.local2>
 <20160908204737.GA12164@breadbox.private.spodhuis.org>
 <20160908211643.GA4432@fujitsu.shahaf.local2>
 <20160909005557.GB12371@breadbox.private.spodhuis.org>
 <20160909045739.GA6623@fujitsu.shahaf.local2>
 <20160910010456.GA85981@tower.spodhuis.org>
 <20160910190924.GB4045@fujitsu.shahaf.local2>
 <20160911192351.GA28725@tower.spodhuis.org>
 <20160912035025.GA32028@fujitsu.shahaf.local2>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20160912035025.GA32028@fujitsu.shahaf.local2>
OpenPGP: url=https://www.security.spodhuis.org/PGP/keys/0x4D1E900E14C1CC04.asc

On 2016-09-12 at 03:50 +0000, Daniel Shahaf wrote:
> A comma is missing after the first "yes":
> 
> +  AC_TRY_RUN([
> ⋮
> +}],
> +  zsh_cv_cre2_runtime_broken=no,
> +  zsh_cv_cre2_runtime_broken=yes
> +  zsh_cv_cre2_runtime_broken=yes))

*facepalm*

Thank you.

diff --git a/configure.ac b/configure.ac
index c000d6a..f055583 100644
--- a/configure.ac
+++ b/configure.ac
@@ -718,8 +718,8 @@ int main(int argc, char **argv) {
        return 0;
 }],
   zsh_cv_cre2_runtime_broken=no,
-  zsh_cv_cre2_runtime_broken=yes
-  zsh_cv_cre2_runtime_broken=yes))
+  zsh_cv_cre2_runtime_broken=yes,
+  zsh_cv_cre2_runtime_broken=unknown))
   if test x$zsh_cv_cre2_runtime_broken = xyes; then
     AC_MSG_ERROR([cre2 library hard-unusable, rebuild with same compiler as for RE2])
   fi