From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: zsh-workers@zsh.org
Subject: Re: Off-by-one with select-*-shell-word text object?
Date: Mon, 19 Sep 2016 07:00:21 +0000 [thread overview]
Message-ID: <20160919070020.GA3836@fujitsu.shahaf.local2> (raw)
In-Reply-To: <160917072918.ZM29255@torch.brasslantern.com>
Bart Schaefer wrote on Sat, Sep 17, 2016 at 07:29:18 -0700:
> On Sep 17, 7:42am, Daniel Shahaf wrote:
> }
> } I think it would be cleaner to invent a new bitmask flag and set it on
> } the affected widgets (select-*-word, run-help, etc) than to overload
> } WIDGET_INT for this purpose.
>
> It's not overloading WIDGET_INT, it's overloading ZLE_VIOPER - because
> those are the only cases of builtins that want the opposite case (point
> to the caller). Testing WIDGET_INT is only necessary because the sense
> of setbindk is reversed from the sense of ZLE_VIOPER.
>
The code tests that ZLE_VIOPER is unset and that WIDGET_INT is set;
therefore, any widget implemented in a module will have $WIDGET pointing
to itself, unless that widget has ZLE_VIOPER set.
As Oliver said, aside from the vi operator widgets, only 4 builtin
widgets care about whether $WIDGET points to themselves or not. There
is no reason, AIUI, to force set_bindk to 1 for the other 390 builtin
widgets, as well as for all future widgets implemented in modules.
That's why I suggested to invent a new bitmask flag that implies
set_bindk on a per-widget basis: the property 'requires $WIDGET to be
self-referential' does not follow from 'is implemented in C'. I can
also imagine future user-defined widgets that need $WIDGET to always
point to themselves.
> } Whether a widget is implemented in C or in shell has no bearing on
> } whether it assumes that $WIDGET points to itself.
>
> At the moment that's not true; a widget implemented in shell can never
> safely assume that $WIDGET points to itself.
I am not arguing that widgets implemented in shell should be able to
assume that $WIDGET is self-referential. I am arguing that widgets
implemented in C should not be able to to assume that. (unless they
have that new bitmask flag I'm proposing)
Cheers,
Daniel
next prev parent reply other threads:[~2016-09-19 7:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 17:21 Bart Schaefer
2016-09-16 20:47 ` Oliver Kiddle
2016-09-16 21:22 ` Bart Schaefer
2016-09-16 23:30 ` Oliver Kiddle
2016-09-17 3:02 ` Bart Schaefer
2016-09-17 7:42 ` Daniel Shahaf
2016-09-17 14:29 ` Bart Schaefer
2016-09-19 7:00 ` Daniel Shahaf [this message]
2016-09-19 10:01 ` Oliver Kiddle
2016-09-19 15:19 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160919070020.GA3836@fujitsu.shahaf.local2 \
--to=d.s@daniel.shahaf.name \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).