From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-39411-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 17464 invoked by alias); 22 Sep 2016 12:00:31 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 39411
Received: (qmail 20816 invoked from network); 22 Sep 2016 12:00:31 -0000
X-Qmail-Scanner-Diagnostics: from out2-smtp.messagingengine.com by f.primenet.com.au (envelope-from <d.s@daniel.shahaf.name>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1.  
 Clear:RC:0(66.111.4.26):SA:0(0.0/5.0):. 
 Processed in 0.142234 secs); 22 Sep 2016 12:00:31 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=0.0 required=5.0 tests=T_DKIM_INVALID
	autolearn=unavailable autolearn_force=no version=3.4.1
X-Envelope-From: d.s@daniel.shahaf.name
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=
	daniel.shahaf.name; h=cc:content-type:date:from:in-reply-to
	:message-id:mime-version:references:subject:to:x-sasl-enc
	:x-sasl-enc; s=mesmtp; bh=gboGk3PKeWaZD2WQ3Mwjy4HQl48=; b=LyKt+k
	4KJ8RS0aPFdC2EICw8wU1XlADwsnyG4dKxmvg2dqvDwYBYDKJYCCeDbVlXI82c4V
	mRdGd8Zs1fRI7pzL6VRD+XtzBLWNaSaipWojSwzhWnQeiIQ3OPYosNzhUfYLGF4M
	6jnFrd+ZElgv93Gs4b/fSME5oGmwL206qebco=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:content-type:date:from:in-reply-to
	:message-id:mime-version:references:subject:to:x-sasl-enc
	:x-sasl-enc; s=smtpout; bh=gboGk3PKeWaZD2WQ3Mwjy4HQl48=; b=tOuTk
	/iJlGXnmHCqS/FTYIUfsXJv46/qy99uzFmq+nc3s+F/Y/pdLoTmoYuOs7DkE55oj
	Y/DTvLD5Y3EBhSHVYe0MOvv8bGl2TOdBGnf8NcdOVZG3pP9ZMajiaoYaWSDoVrJt
	apZsKl59Xkn2w1TZZA8AOSD4mCCWDKSaT2Bmkg=
X-Sasl-enc: E6WPtoBJ4MZHxxbzPTzTzP9t1iGsyMzui1+oa/5IvSo8 1474545628
Date: Thu, 22 Sep 2016 11:59:21 +0000
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Peter Stephenson <p.w.stephenson@ntlworld.com>
Cc: zsh-workers@zsh.org
Subject: Re: Bug related to stdin/always/jobcontrol
Message-ID: <20160922115921.GA3613@fujitsu.shahaf.local2>
References: <87r392jgd0.fsf@juno.home.vuxu.org>
 <20160905164207.4630643b@pwslap01u.europe.root.pri>
 <CGME20160914173110eucas1p1f0567e319ae439b975b19f4e55676fed@eucas1p1.samsung.com>
 <20160914183105.69862fa9@pwslap01u.europe.root.pri>
 <20160914223553.3173c8ca@ntlworld.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20160914223553.3173c8ca@ntlworld.com>
User-Agent: Mutt/1.5.23 (2014-03-12)

Peter Stephenson wrote on Wed, Sep 14, 2016 at 22:35:53 +0100:
> On Wed, 14 Sep 2016 18:31:05 +0100
> Peter Stephenson <p.stephenson@samsung.com> wrote:
> > I think I might be getting close with the attached patch... first
> > guess is we need to create a new process group, or something.
> 
> The subjob needs to keep its process group because it's too late to
> change it; I found out what was missing, it needs process group leader
> assigning from that of list_pipe_job (obviously, right?)  Seems a bit
> weird this never got noticed before, but it's hard to see how it can be
> wrong since this is the way the pipeline always works, regardless of
> whether the ls process or equivalent has exited.  I've tried a few bits
> of job control with multiple different list-pipe-style constructs lying
> around and they still seem to work.

This (39331) broke fg'ing a function for me:

% print $ZSH_PATCHLEVEL 
zsh-5.2-dev-1-401-g4e51079
% f() { $EDITOR } 
% f
<press ^Z in the editor>
zsh: suspended  f
% fg
[1]  + continued  f
zsh: suspended (tty output)  f

After the 'fg' I get another prompt immediately, instead of being
returend to $EDITOR.

Cheers,

Daniel