From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5095 invoked by alias); 26 Sep 2016 11:31:06 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 39443 Received: (qmail 19528 invoked from network); 26 Sep 2016 11:31:06 -0000 X-Qmail-Scanner-Diagnostics: from mailout4.w1.samsung.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(210.118.77.14):SA:0(-3.1/5.0):. Processed in 0.45125 secs); 26 Sep 2016 11:31:06 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=RP_MATCHES_RCVD autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: p.stephenson@samsung.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at samsung.com does not designate permitted sender hosts) X-AuditID: cbfec7f2-f79556d000002c42-63-57e90496533f Date: Mon, 26 Sep 2016 12:20:51 +0100 From: Peter Stephenson To: zsh-workers@zsh.org Subject: Re: struct job.other (was Re: Bug related to stdin/always/jobcontrol) Message-id: <20160926122051.17a8bebf@pwslap01u.europe.root.pri> In-reply-to: <160925155436.ZM23968@torch.brasslantern.com> Organization: Samsung Cambridge Solution Centre X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu) MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrLIsWRmVeSWpSXmKPExsWy7djPc7rTWF6GG3zvE7M42PyQyYHRY9XB D0wBjFFcNimpOZllqUX6dglcGZM3N7IWtHNWXFi+kr2B8TtbFyMnh4SAicSUw6cYIWwxiQv3 1gPFuTiEBJYySry98I4dwullkmiaeoAVpuPxgU5WiMQyRonrZycyQTjTmCT6el4xQzhnGCXu r3nBCOGcZZS4s2kfE0g/i4CqxJePd9hBbDYBQ4mpm2aDbRcREJc4u/Y8C4gtLBAgcfDQTGYQ m1fAXmLKkhlgNqeAlcS5tw/B6vkF9CWu/v3EBHGTvcTMK2cYIeoFJX5Mvgc2h1lAR2Lbtsfs ELa8xOY1b8GukxD4zyaxb/Z2oAQHkCMrsekAM4TpIvHoOyfESGGJV8e3sEPYMhKdHQehVvUz Sjzp9oUYM4NR4vSZHdCQtJbou32REWIXn8SkbdOhZvJKdLQJQZR4SDx/1QENRkeJq1/6mSYw Ks5CcvUsJFfPQnL1AkbmVYwiqaXFuempxcZ6xYm5xaV56XrJ+bmbGIGJ4PS/4592MH49YXWI UYCDUYmH1+Pw83Ah1sSy4srcQ4wSHMxKIrzm/1+EC/GmJFZWpRblxxeV5qQWH2KU5mBREufd s+BKuJBAemJJanZqakFqEUyWiYNTqoEx4Fr/xXmZkxzqbgr0hi27c2CS7lqVEK2Nczq89rb/ eWbkdPiuUYTCsWeJM+/K7nX/IN1Rv1PceM21VV477s0NNxX6e+i2oupv0wur2I6rm83c9/fK hzzx5ZO3/37P831+rm7IGu2lobWb4w5I3D2SwMvF7+Uv81jy9Ibpt0tnP/f5J39155eCMCWW 4oxEQy3mouJEANU6594AAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrOIsWRmVeSWpSXmKPExsVy+t/xa7pFLC/DDTbukbE42PyQyYHRY9XB D0wBjFFuNhmpiSmpRQqpecn5KZl56bZKoSFuuhZKCnmJuam2ShG6viFBSgpliTmlQJ6RARpw cA5wD1bSt0twy5i8uZG1oJ2z4sLylewNjN/Zuhg5OSQETCQeH+hkhbDFJC7cWw8U5+IQEljC KPFr1jd2CGcGk8THXbMYIZxzjBJnTtyGKjvLKLHrZgsTSD+LgKrEl4932EFsNgFDiambZjOC 2CIC4hJn155nAbGFBfwkPh09DBbnFbCXmLJkBjOIzSlgJXHu7UOoDQ0sEg0H2sAa+AX0Ja7+ /cQEcaC9xMwrZ6CaBSV+TL4HVsMsoCWxeVsTK4QtL7F5zVuwoUIC6hI37u5mn8AoPAtJyywk LbOQtCxgZF7FKJJaWpybnltsqFecmFtcmpeul5yfu4kRGEnbjv3cvIPx0sbgQ4wCHIxKPLwe h5+HC7EmlhVX5h5ilOBgVhLhNf//IlyINyWxsiq1KD++qDQntfgQoykwZCYyS4km5wOjPK8k 3tDE0NzS0MjYwsLcyEhJnLfkw5VwIYH0xJLU7NTUgtQimD4mDk6pBsZQ4a4pRfIpR9+0rcvb IFShIvR5tdLT3VfecX3lm3Vs3iwlLSFOHuatrJ7ev7Wu9qydxm8m/JhlU3TCGQGhV6c3bD/d 8PUd54yCY9IcXAFqf+J291i8ObbGKErPk7nqm4s6m93n32nzzC4tbclYM3vq07ICxTXRZQes yowaz9e79N09ZT9zSa8SS3FGoqEWc1FxIgC+M77JugIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20160926112053eucas1p13ca5c87b90b25c36cee5acc3dedc295c X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?UGV0ZXIgU3RlcGhlbnNvbhtTQ1NDLURhdGEgUGxhbmUb?= =?UTF-8?B?7IK87ISx7KCE7J6QG1ByaW5jaXBhbCBFbmdpbmVlciwgU29mdHdhcmU=?= X-Global-Sender: =?UTF-8?B?UGV0ZXIgU3RlcGhlbnNvbhtTQ1NDLURhdGEgUGxhbmUbU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtQcmluY2lwYWwgRW5naW5lZXIsIFNvZnR3YXJl?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDA1Q0QwNTAwNTg=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20160914173110eucas1p1f0567e319ae439b975b19f4e55676fed X-RootMTR: 20160914173110eucas1p1f0567e319ae439b975b19f4e55676fed References: <87r392jgd0.fsf@juno.home.vuxu.org> <20160905164207.4630643b@pwslap01u.europe.root.pri> <20160914183105.69862fa9@pwslap01u.europe.root.pri> <20160914223553.3173c8ca@ntlworld.com> <20160922115921.GA3613@fujitsu.shahaf.local2> <160922093838.ZM7266@torch.brasslantern.com> <160922181847.ZM22524@torch.brasslantern.com> <20160925153924.7e741ffc@ntlworld.com> <160925155436.ZM23968@torch.brasslantern.com> On Sun, 25 Sep 2016 15:54:36 -0700 Bart Schaefer wrote: > On Sep 25, 3:39pm, Peter Stephenson wrote: > } > } > jn->other is a job table index, not a process ID. > } > } The code's correct as it stands (modulo problems setting the values it's > } using) -- read my previous explanations and the updated comment in zsh.h > > OK, thanks ... how about this: > > diff --git a/Src/exec.c b/Src/exec.c > index 4e89340..c27c41c 100644 > --- a/Src/exec.c > +++ b/Src/exec.c > @@ -1702,7 +1702,7 @@ execpline(Estate state, wordcode slcode, int how, int last1) > jobtab[list_pipe_job].other = newjob; > jobtab[list_pipe_job].stat |= STAT_SUPERJOB; > jn->stat |= STAT_SUBJOB | STAT_NOPRINT; > - jn->other = pid; > + jn->other = list_pipe_pid; /* see zsh.h */ > if (hasprocs(list_pipe_job)) > jn->gleader = jobtab[list_pipe_job].gleader; > } > That's OK; I assume there's no race where list_pipe_pid is set to something else since signals are blocked. Same thing happens at line 1597, which is the code I added for the new case with "ls | func". pws