zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.stephenson@samsung.com>
To: zsh-workers@zsh.org
Subject: Re: BUG: crafting SHELLOPTS and PS4 allows to run arbitrary programs in setuid binaries using system
Date: Tue, 27 Sep 2016 10:28:15 +0100	[thread overview]
Message-ID: <20160927102815.26de2501@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <37737.1474966607@hydra.kiddle.eu>

On Tue, 27 Sep 2016 10:56:47 +0200
Oliver Kiddle <okiddle@yahoo.co.uk> wrote:
> Zsh also needs the prompt_subst option to enable command substitution in
> PS4. Perhaps there's an argument for not importing PS4 from the
> environment in certain cases anyway but I can't see any security issue.

PROMPT_SUBST is enabled in any sh-style emulation, so that's an issue.

I can't offhand think of any way of turning on XTRACE from the
environment, though.  Note that $_ is already marked PM_DONTIMPORT.

pws


      reply	other threads:[~2016-09-27  9:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-27  6:59 Mateusz Lenik
2016-09-27  7:53 ` Daniel Shahaf
2016-09-27  8:43   ` Mateusz Lenik
2016-09-27  9:02   ` Peter Stephenson
2016-09-27 19:26     ` Bart Schaefer
2016-09-28 10:37     ` Simon Ruderich
2016-09-28 19:04       ` Bart Schaefer
2016-09-29 13:20       ` Peter Stephenson
2016-09-27  8:56 ` Oliver Kiddle
2016-09-27  9:28   ` Peter Stephenson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160927102815.26de2501@pwslap01u.europe.root.pri \
    --to=p.stephenson@samsung.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).