From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-39558-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 24424 invoked by alias); 4 Oct 2016 17:35:26 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 39558
Received: (qmail 24646 invoked from network); 4 Oct 2016 17:35:26 -0000
X-Qmail-Scanner-Diagnostics: from out4-smtp.messagingengine.com by f.primenet.com.au (envelope-from <d.s@daniel.shahaf.name>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1.  
 Clear:RC:0(66.111.4.28):SA:0(0.0/5.0):. 
 Processed in 0.593639 secs); 04 Oct 2016 17:35:26 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=0.0 required=5.0 tests=T_DKIM_INVALID
	autolearn=unavailable autolearn_force=no version=3.4.1
X-Envelope-From: d.s@daniel.shahaf.name
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=
	daniel.shahaf.name; h=content-type:date:from:in-reply-to
	:message-id:mime-version:references:subject:to:x-sasl-enc
	:x-sasl-enc; s=mesmtp; bh=xMm5WdR7OosGPqVsJfam3+y2kr4=; b=F1kuJl
	Ce+0qbC23hDlU++rZOZQjXC7dCb6yP4aUTIils+kmU513W744eZZygDSZaUCRhrQ
	vGVvqROWY7hTGVOxRB1Ycv6uP2UgWliE4HKFPe2XjwpH5AEzjuryNppoZ3dWlst3
	WY/4C0HOF6tlO3Y+Szdjlqwe2FYXXNWM7sKgk=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=
	messagingengine.com; h=content-type:date:from:in-reply-to
	:message-id:mime-version:references:subject:to:x-sasl-enc
	:x-sasl-enc; s=smtpout; bh=xMm5WdR7OosGPqVsJfam3+y2kr4=; b=GH7n7
	L2XlyfMzSpGDRovzWPtPOuU5KVMKcwkYTJX3IVowgD9Va6hFlUZ6d4Alsp1dEJK/
	/55WQt68+3anzZy+LgOAJ3ASzpdm6RO56ivp8XpilUEmJsu3MN6uvVcB/v1eaM82
	6tlCGpKZKacxWrOlkoUZ3tO9caM8DZhxrnFBs4=
X-Sasl-enc: 3pcymhumxWIgrXrmPxB0wVikgBqnN+93H4NSKYWKYcMy 1475602072
Date: Tue, 4 Oct 2016 17:26:23 +0000
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Zsh workers <zsh-workers@zsh.org>
Subject: Re: PATCH: git completion - pass on --git-dir option
Message-ID: <20161004172623.GA28109@fujitsu.shahaf.local2>
References: <80219.1475219575@hydra.kiddle.eu>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <80219.1475219575@hydra.kiddle.eu>
User-Agent: Mutt/1.5.23 (2014-03-12)

Oliver Kiddle wrote on Fri, Sep 30, 2016 at 09:12:55 +0200:
> Various aspects of git completion don't work if the option --git-dir is
> used. This solves that by putting the value in $GIT_DIR.
> 
> +++ b/Completion/Unix/Command/_git
> @@ -7484,7 +7484,7 @@ _git() {
> +	(( $+opt_args[--git-dir] )) && local -x GIT_DIR=$opt_args[--git-dir]

Also for --work-tree/GIT_WORK_TREE?

There are other --option/ENVVAR pairs in git(1), but I don't know
whether it is important for them to get this treatment too.

Cheers,

Daniel