From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26665 invoked by alias); 7 Oct 2016 14:01:20 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 39584 Received: (qmail 9050 invoked from network); 7 Oct 2016 14:01:19 -0000 X-Qmail-Scanner-Diagnostics: from out5-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(66.111.4.29):SA:0(0.0/5.0):. Processed in 0.31625 secs); 07 Oct 2016 14:01:19 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= daniel.shahaf.name; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=mesmtp; bh=YSWRZH2sG3b0KKKhXOuTe++2oqw=; b=UxaQP/ a5PgdY0L0m0XM5uYx0cF3V2KJoCdnsu+VzqcqOb5dvsD34o2UNvd8GozYn8HTSaM Dyu1NTHq72vFmSM4v9PpqOty11H417FLpAPL2v8pSUvLmgrVaoKu/H911RQr4Af4 sXNtOnP1Vp3ww5ojvbxKjo6zTqSbmBB6jOk8U= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=YSWRZH2sG3b0KKKhXOuTe++2oqw=; b=pjH// TaeeVjYQNf7ngFrhEr/MJE7wjo3dm/6CF2Xo5GQwvdx9JoKQFVZw8UYwDTlFY8d2 tfhDBTaxiljJCCpPc4IP+YzexS3PlBTpK36nzcElALHgdpeBw16bwgGHNmu2SF7C WnJGiae8SbftHfGdJcFnoEPNDj5/HD+M7sywPo= X-Sasl-enc: G95tz33Yl2n8YZEhNHf8H1T6PJuvPkfh3AZnURCGOeBt 1475848334 Date: Fri, 7 Oct 2016 13:50:44 +0000 From: Daniel Shahaf To: zsh-workers@zsh.org Subject: Re: [PATCH] _describe and literal \n Message-ID: <20161007135044.GA13064@fujitsu.shahaf.local2> References: <20160723180430.GA22451@tarsus.local2> <160723130059.ZM19333@torch.brasslantern.com> <20160723212345.GA2982@tarsus.local2> <5530.1469316428@hydra.kiddle.eu> <20160724213046.GB27932@tarsus.local2> <92023.1475008338@hydra.kiddle.eu> <20160929141139.GA5059@fujitsu.shahaf.local2> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160929141139.GA5059@fujitsu.shahaf.local2> User-Agent: Mutt/1.5.23 (2014-03-12) Daniel Shahaf wrote on Thu, Sep 29, 2016 at 14:11:39 +0000: > compadd prints the description using nice*() functions, but _describe > does its width computations using the raw string length; hence compadd > prints a longer string than _describe computed. > > @@ -199,11 +199,11 @@ cd_calc(void) > - if ((l = MB_METASTRWIDTH(str->str)) > cd_state.premaxw) > + if ((l = ZMB_nicewidth(str->str)) > cd_state.premaxw) I haven't forgotten about this; I'd like to review it again before pushing, but haven't yet had time to do so.