From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29389 invoked by alias); 14 Oct 2016 06:21:26 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 39631 Received: (qmail 15548 invoked from network); 14 Oct 2016 06:21:26 -0000 X-Qmail-Scanner-Diagnostics: from out1-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(66.111.4.25):SA:0(0.0/5.0):. Processed in 0.656927 secs); 14 Oct 2016 06:21:26 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= daniel.shahaf.name; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=g9bC7Bawz2BAn2ro WqYf09EEnWE=; b=1SeQNzjKK80LGCKkdzPckj5t/um5Vp/WCrTQZSSiOdVhEghS 6ZwdrZtoOYnKkVkWZimQof4pTgh/xVg0BSYC3wGa9bfXZmNc1TcFgVRU5dqBn2Ku 8Ebs49uwfTJO4TRFzdhAUqcu1N9ucaYgr7utCLGgwRBfSAHztROkBQK6jEY= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-sasl-enc:x-sasl-enc; s=smtpout; bh=g9bC7Bawz2BAn2r oWqYf09EEnWE=; b=NAMl1Ha55S88r3D/dzAOdYh4SPpeXhppSa9TU166SslHijp gwjt8ZzOWk/+f6Die2ENxkV62yAvTWLCjoUX7JdxHWWh4Axm7ejAWDWIyrkeX7H1 Xa+MSNFYu5KvUdmtvSPvma1PdNujxp/QurGKbixJtLacO/ViDAsrFgNol+Do= X-Sasl-enc: QuTEzfjIL6K3EoGv49voguVhau7rIxyy2TYpurKt3BoW 1476425540 Date: Fri, 14 Oct 2016 06:10:33 +0000 From: Daniel Shahaf To: zsh-workers@zsh.org Cc: Guilherme Salazar Subject: Re: zsh make(1) completion on FreeBSD Message-ID: <20161014061033.GA11115@fujitsu.shahaf.local2> References: <20161011212150.GA24484@fujitsu.shahaf.local2> <20161012000249.GA32367@fujitsu.shahaf.local2> <20161012003606.GB32367@fujitsu.shahaf.local2> <10086.1476353312@hydra.kiddle.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <10086.1476353312@hydra.kiddle.eu> User-Agent: Mutt/1.5.23 (2014-03-12) Oliver Kiddle wrote on Thu, Oct 13, 2016 at 12:08:32 +0200: > As for fixing inconsistencies, it depends: > The trouble with patches that only fix indentation is that they can make > it harder to follow git history. git diff and blame do have a -w option > but still. > > In the case of completions, I correct the indentation when making > changes that affect many lines. For example, _zfs has capitalised > descriptions so it would be reasonable to reindent it if also > correcting the descriptions to follow the convention of all lowercase: > descriptions appear on most lines. Agreed that a patch that touches a line can fix indentation on that line; doing so doesn't make 'blame' any harder to read. However, some other kinds of style changes should be done in separate commits. For example, the _tmux part of 39067 deleted the «function» keyword and the $args arrays, whilst also making other changes; consequently it was very hard to review.¹ I think those two file-wide changes are examples of style changes that shouldn't be done in the same commit as functional changes. (Incidentally, I prefer having $args arrays to multiline _arguments calls because the former (a) is immune to "Forgot to append a backslash" bugs, (b) allows writing comments between option specifications.) Cheers, Daniel ¹ That reminds me of the infamous "goto fail" bug.