From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3535 invoked by alias); 16 Oct 2016 15:15:49 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 39652 Received: (qmail 19905 invoked from network); 16 Oct 2016 15:15:49 -0000 X-Qmail-Scanner-Diagnostics: from out1-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(66.111.4.25):SA:0(0.0/5.0):. Processed in 0.401716 secs); 16 Oct 2016 15:15:49 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= daniel.shahaf.name; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=mesmtp; bh=Cn+8CRO6T1yi8BK5ZYujF5yM+yk=; b=Wc0heH s/Gy58JZLgUv/xPA/k9XZ1EpF7xkjbEX4cKCwMuUD48gaAkfiF2qTv3153qqqz5/ 9WdvYx8+othT8vxVJ+cpcUT9tUzfu1aw2UAg2CABXWIK+ia0ogobzV5RBpeWEubu udgSOKPqaMiJejIZEj1Uu65OhNVkJpOtDB2mU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=Cn+8CRO6T1yi8BK5ZYujF5yM+yk=; b=bx6Gw j0rb6sYq/8bxtyiMS89qBNmzNJSD9LBRqSDAXh9KzChAgxwR93NYr5qnwofcrwIT 0evVD4MklSCfxaZg8JUC92FbBoGETPgwd70qVmHq69cyNMpbyRe3duGkL0bhtI42 WwUSaWbE1itOZaGqATy9MC0uzOzZ8tdNf6KCNc= X-Sasl-enc: 5obqjjPqvuj8SAHVdfxxGYsHsxBrF+KwUDPLPw73RfsC 1476630941 Date: Sun, 16 Oct 2016 15:13:54 +0000 From: Daniel Shahaf To: zsh-workers@zsh.org Cc: m0viefreak Subject: Re: [PATCH] zle: Call zle-line-pre-redraw after inserting a completion result Message-ID: <20161016151354.GA21942@fujitsu.shahaf.local2> References: <43c19ce7-6445-8b56-68e7-60fc82258183@googlemail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <43c19ce7-6445-8b56-68e7-60fc82258183@googlemail.com> User-Agent: Mutt/1.5.23 (2014-03-12) m0viefreak wrote on Sat, Oct 08, 2016 at 19:30:16 +0200: > This patch originated from a zsh-synatx-highlighting issue: > https://github.com/zsh-users/zsh-syntax-highlighting/issues/375 > > I think redrawhook() should be called at the end of do_single() > to make sure that zle-line-pre-redraw is run when cycling the results of > a menu completion. Any thoughts on the patch? With my z-sy-h hat, I confirm it behaves as promised (applies highlighting whilst tabbing through menu completion), but with my zsh hat, I am not familiar with zle enough to review this patch. Cheers, Daniel > From 6c1e1fe71011f8617a85fb2d53b7a36c8fcd0d07 Mon Sep 17 00:00:00 2001 > From: m0viefreak > Date: Sat, 8 Oct 2016 18:53:55 +0200 > Subject: [PATCH] zle: Call zle-line-pre-redraw after inserting a completion > result > > This is necessary to make sure redrawhook() is called while > cycling results in menu completion. > --- > Src/Zle/compresult.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Src/Zle/compresult.c b/Src/Zle/compresult.c > index 7fec7c8..b7ec18f 100644 > --- a/Src/Zle/compresult.c > +++ b/Src/Zle/compresult.c > @@ -1191,6 +1191,7 @@ do_single(Cmatch m) > if (menucmp) > minfo.cur = &m; > runhookdef(INSERTMATCHHOOK, (void *) &dat); > + redrawhook(); > minfo.cur = om; > } > }