From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22490 invoked by alias); 17 Oct 2016 08:49:13 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 39664 Received: (qmail 21422 invoked from network); 17 Oct 2016 08:49:13 -0000 X-Qmail-Scanner-Diagnostics: from mailout4.w1.samsung.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(210.118.77.14):SA:0(-0.4/5.0):. Processed in 0.17175 secs); 17 Oct 2016 08:49:13 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-0.4 required=5.0 tests=RP_MATCHES_RCVD autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: p.stephenson@samsung.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at samsung.com does not designate permitted sender hosts) X-AuditID: cbfec7f4-f791c6d000006eac-9c-58048e278482 Date: Mon, 17 Oct 2016 09:39:02 +0100 From: Peter Stephenson To: zsh-workers@zsh.org Subject: Re: [PATCH] zle: Call zle-line-pre-redraw after inserting a completion result Message-id: <20161017093902.0a7dd896@pwslap01u.europe.root.pri> In-reply-to: <20161016151354.GA21942@fujitsu.shahaf.local2> Organization: Samsung Cambridge Solution Centre X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu) MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrDIsWRmVeSWpSXmKPExsWy7djPc7rqfSwRBv9+GlkcbH7I5MDoserg B6YAxigum5TUnMyy1CJ9uwSujNUr7rIXvGateDLXvoHxDksXIweHhICJxI7Jcl2MnECmmMSF e+vZuhi5OIQEljJKdE69wwrh9DJJNO+eywRRZSKxZecRJojEMkaJXXfnMUI405gkrn64wgzh nGGU2LTrFlTmLKPE7A0P2ED6WQRUJb4e/M4IYrMJGEpM3TQbzBYREJc4u/Y8C4gtLBAh0XPw KTOIzStgL/Gn5yBYL6eAtcT0H7/AavgF9CWu/v0EdZO9xMwrZxgh6gUlfky+B1bDLKAjsW3b Y3YIW15i85q3YNdJCPxnk2g9s5IREgKyEpsOMEPMcZGYcPs/1ExhiVfHt7BD2DISlyd3s0DY /YwST7p9IebMYJQ4fWYHG0TCWqLv9kVGiGV8EpO2TWeGmM8r0dEmBFHiIbH983GomY4SO/Yt YJvAqDgLydmzkJw9C8nZCxiZVzGKpJYW56anFpvoFSfmFpfmpesl5+duYgSmgdP/jn/Zwbj4 mNUhRgEORiUe3hvzmSKEWBPLiitzDzFKcDArifC+r2GJEOJNSaysSi3Kjy8qzUktPsQozcGi JM67Z8GVcCGB9MSS1OzU1ILUIpgsEwenVANjrbrZbfEFzr75i/9cyjQua02W236XtVlazbEx pSQ3gmOb/+nWJu7keSfELnY4G1T8+HT11ZtpNdt1aiZNFP3UyRBS7GacvH0yZ8aDGR5LvJUm G36eHmRk6MW4dnqum4hKRMKvlSF3Hy3gfTXVKb/y3porUj929naa7upb2DQ/gWGF5jKej2JK LMUZiYZazEXFiQAwogGJ/wIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGIsWRmVeSWpSXmKPExsVy+t/xy7qMfSwRBit6xS0ONj9kcmD0WHXw A1MAY5SbTUZqYkpqkUJqXnJ+SmZeuq1SaIibroWSQl5ibqqtUoSub0iQkkJZYk4pkGdkgAYc nAPcg5X07RLcMlavuMte8Jq14slc+wbGOyxdjJwcEgImElt2HmGCsMUkLtxbz9bFyMUhJLCE UaJ52zkmCGcGk8SBWbOYIZxzjBIfd3ZAlZ1llNh/bhUrSD+LgKrE14PfGUFsNgFDiambZoPZ IgLiEmfXngfbJywQIbFg72mwel4Be4k/PQfZQGxOAWuJ6T9+sUAMPcYo0dP8E+wofgF9iat/ P0EdaC8x88oZRohmQYkfk++BDWUW0JLYvK2JFcKWl9i85i0ziC0koC5x4+5u9gmMwrOQtMxC 0jILScsCRuZVjCKppcW56bnFRnrFibnFpXnpesn5uZsYgXG07djPLTsYu94FH2IU4GBU4uG9 MZ8pQog1say4MvcQowQHs5II7/salggh3pTEyqrUovz4otKc1OJDjKbAkJnILCWanA+M8byS eEMTQ3NLQyNjCwtzIyMlcd6pH66ECwmkJ5akZqemFqQWwfQxcXBKNTDWq5Td3WezcXXkhJbd 946l7j6e1VZ6fqFaWq1Pdjen/v9bp+8bS6yYqKjBvEVzFk/iqzRPno+2S5tF/iY/kXDNniLj 8rnfL02m9PfPVk39p9bCzD4vP57ujvFz2rlyc0H384k+83zK7kmumV5leLZUI0yO902WoPEr S94Tk9pjszZX8ca0/VViKc5INNRiLipOBAAF+bkwuQIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20161017083903eucas1p24df9de8892e30260c0f60ff3082e15fa X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?UGV0ZXIgU3RlcGhlbnNvbhtTQ1NDLURhdGEgUGxhbmUb?= =?UTF-8?B?7IK87ISx7KCE7J6QG1ByaW5jaXBhbCBFbmdpbmVlciwgU29mdHdhcmU=?= X-Global-Sender: =?UTF-8?B?UGV0ZXIgU3RlcGhlbnNvbhtTQ1NDLURhdGEgUGxhbmUbU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtQcmluY2lwYWwgRW5naW5lZXIsIFNvZnR3YXJl?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDA1Q0QwNTAwNTg=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20161016151617eucas1p1a7efec6a67f7012cf1c11c9d22622a2c X-RootMTR: 20161016151617eucas1p1a7efec6a67f7012cf1c11c9d22622a2c References: <43c19ce7-6445-8b56-68e7-60fc82258183@googlemail.com> <20161016151354.GA21942@fujitsu.shahaf.local2> On Sun, 16 Oct 2016 15:13:54 +0000 Daniel Shahaf wrote: > m0viefreak wrote on Sat, Oct 08, 2016 at 19:30:16 +0200: > > This patch originated from a zsh-synatx-highlighting issue: > > https://github.com/zsh-users/zsh-syntax-highlighting/issues/375 > > > > I think redrawhook() should be called at the end of do_single() > > to make sure that zle-line-pre-redraw is run when cycling the results of > > a menu completion. > > Any thoughts on the patch? With my z-sy-h hat, I confirm it behaves as > promised (applies highlighting whilst tabbing through menu completion), > but with my zsh hat, I am not familiar with zle enough to review this > patch. I can't see anything obviously wrong with it. pws