From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-39684-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 6125 invoked by alias); 20 Oct 2016 10:18:33 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 39684
Received: (qmail 25766 invoked from network); 20 Oct 2016 10:18:33 -0000
X-Qmail-Scanner-Diagnostics: from mailout2.w1.samsung.com by f.primenet.com.au (envelope-from <p.stephenson@samsung.com>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1.  
 Clear:RC:0(210.118.77.12):SA:0(-0.3/5.0):. 
 Processed in 0.458469 secs); 20 Oct 2016 10:18:33 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-0.3 required=5.0 tests=RP_MATCHES_RCVD
	autolearn=unavailable autolearn_force=no version=3.4.1
X-Envelope-From: p.stephenson@samsung.com
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
Received-SPF: none (ns1.primenet.com.au: domain at samsung.com does not designate permitted sender hosts)
X-AuditID: cbfec7f2-f79556d000002c42-70-580899ee33c7
Date: Thu, 20 Oct 2016 11:18:19 +0100
From: Peter Stephenson <p.stephenson@samsung.com>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Cores almost on demand in patcompile()
Message-id: <20161020111819.4088896a@pwslap01u.europe.root.pri>
In-reply-to:
 <CAKc7PVA_NYiawEb=D+dP_ZZC==TqLxnQ4YqFLzQQQUPYKzrhZA@mail.gmail.com>
Organization: Samsung Cambridge Solution Centre
X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu)
MIME-version: 1.0
Content-type: text/plain; charset=US-ASCII
Content-transfer-encoding: 7bit
X-Brightmail-Tracker:
 H4sIAAAAAAAAA+NgFnrLIsWRmVeSWpSXmKPExsWy7djP87rvZnJEGPQt0bI42PyQyYHRY9XB
	D0wBjFFcNimpOZllqUX6dglcGdMeRRRsZq1Y17WYrYFxEUsXIyeHhICJxNX395ggbDGJC/fW
	s3UxcnEICSxllFja2McI4fQySXy8uYAJpuPp87dMEIlljBKd63eyQzjTmCTu7DwC5ZxhlNi2
	/wGUc5ZRYtbnSWAbWQRUJaZNvcsGYrMJGEpM3TSbEcQWEdCS2HHyJNgOYQFjiak3NoHFeQXs
	JbZcmckKYnMKBEusPHMJrIZfQF/i6t9PUDfZS8y8cgaqXlDix+R7YLuYBXQktm17zA5hy0ts
	XvOWGeQgCYHfbBKrvp4BSnAAObISmw4wQ8xxkbj88iTUTGGJV8e3sEPYMhKdHQeh4v2MEk+6
	fSHmzGCUOH1mBxtEwlqi7/ZFRohlfBKTtk1nhpjPK9HRJgRR4iHxed5paMg7Spxo/MQ0gVFx
	FpKzZyE5exaSsxcwMq9iFEktLc5NTy021itOzC0uzUvXS87P3cQITASn/x3/tIPx6wmrQ4wC
	HIxKPLwZ59gjhFgTy4orcw8xSnAwK4nwdk7iiBDiTUmsrEotyo8vKs1JLT7EKM3BoiTOu2fB
	lXAhgfTEktTs1NSC1CKYLBMHp1QDo0Cb4L1CL9cHn9b6LzDRfZRSoltU+WeaqXxE3MdV91Xf
	tHwT4XWq5fuad7ui88Xb2jmeCXksiSKLpRVX3FszSZ/dUS761t/VOjXhlY9veVS/3ziDL47P
	WlknbNs3H8PFbZuNkg48y53Grs6dYdCZOXfpTIXPQftkmBf/DV3htGGq08sA2Su6SizFGYmG
	WsxFxYkAdPhdFAADAAA=
X-Brightmail-Tracker:
 H4sIAAAAAAAAA+NgFlrCIsWRmVeSWpSXmKPExsVy+t/xy7r3ZnJEGFzbymdxsPkhkwOjx6qD
	H5gCGKPcbDJSE1NSixRS85LzUzLz0m2VQkPcdC2UFPISc1NtlSJ0fUOClBTKEnNKgTwjAzTg
	4BzgHqykb5fgljHtUUTBZtaKdV2L2RoYF7F0MXJySAiYSDx9/pYJwhaTuHBvPVsXIxeHkMAS
	RonWTb+gnBlMElvn3WKEcM4xSqx5f48NpEVI4CyjxPHXeiA2i4CqxLSpd8HibAKGElM3zWYE
	sUUEtCR2nDwJtkJYwFhi6o1NYHFeAXuJLVdmsnYxcnBwCgRLPPoZBjG/gV1izatvYDX8AvoS
	V/9+gjrPXmLmlTNQvYISPybfA3uBGWj+5m1NrBC2vMTmNW+ZIW5Tl7hxdzf7BEbhWUhaZiFp
	mYWkZQEj8ypGkdTS4tz03GJDveLE3OLSvHS95PzcTYzAGNp27OfmHYyXNgYfYhTgYFTi4bVo
	5YgQYk0sK67MPcQowcGsJMLbOQkoxJuSWFmVWpQfX1Sak1p8iNEUGDATmaVEk/OB8Z1XEm9o
	YmhuaWhkbGFhbmSkJM5b8uFKuJBAemJJanZqakFqEUwfEwenVANjjgWL26MTD6d7X5rzKWmm
	2YuKiaa2/WmLKnNXT5ri/kLRV+vfwQ7Nn4ftfJunSSybwme3rkPv5+Ulsw767+f4p11ZEb7+
	jsjN2NfSz9T3vDJ52GwkXBbZ/6PQLUPg7C7jX4f/Xlzmc0Yhhr12fqTCl5onlWJKc+IY1JoF
	g/7OVpwp8WDdXa5WJZbijERDLeai4kQA152cxbcCAAA=
X-MTR: 20000000000000000@CPGS
X-CMS-MailID: 20161020101822eucas1p1f62833228372dad822d85a7b251fd72a
X-Msg-Generator: CA
X-Sender-IP: 182.198.249.179
X-Local-Sender: =?UTF-8?B?UGV0ZXIgU3RlcGhlbnNvbhtTQ1NDLURhdGEgUGxhbmUb?=
	=?UTF-8?B?7IK87ISx7KCE7J6QG1ByaW5jaXBhbCBFbmdpbmVlciwgU29mdHdhcmU=?=
X-Global-Sender: =?UTF-8?B?UGV0ZXIgU3RlcGhlbnNvbhtTQ1NDLURhdGEgUGxhbmUbU2Ft?=
	=?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtQcmluY2lwYWwgRW5naW5lZXIsIFNvZnR3YXJl?=
X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDA1Q0QwNTAwNTg=?=
CMS-TYPE: 201P
X-HopCount: 7
X-CMS-RootMailID: 20161011044403eucas1p1da8d4beef07f15ef1fb7e821eab83152
X-RootMTR: 20161011044403eucas1p1da8d4beef07f15ef1fb7e821eab83152
References:
 <CAKc7PVBEjPJMtV59CrN6LmrDaoGqfa_DZqwo3Y9HK=+0od7ycA@mail.gmail.com>
 <CAKc7PVCAR2yTJGgdBbvTp=mBC0ZrXcVWW0DE_U26TezSTNdd=A@mail.gmail.com>
 <CAKc7PVB=485r3nRz_pP3A-k-oq2pOp5qYUK7pE1VEApXb0pR1g@mail.gmail.com>
 <CAKc7PVDof_GEuoSv7pg8c1=spXfDkWopP5VR8dVHg-bxXVES1g@mail.gmail.com>
 <CAKc7PVCRtBBVONgiExopYYUv7x4-HN_QEYk-05aoqZihiCRgMw@mail.gmail.com>
 <CGME20161011044403eucas1p1da8d4beef07f15ef1fb7e821eab83152@eucas1p1.samsung.com>
 <CAH+w=7a7jc0Q2=M9aG5mttbazxfsHB-Cz=WwJzCvz_SdnbApRw@mail.gmail.com>
 <20161013104321.29159e3f@pwslap01u.europe.root.pri>
 <CAKc7PVDcPxsm-kn4ReHybLAbCnk+0FrKP18Qp6s76jOf4trBew@mail.gmail.com>
 <20161019141435.42eb6df2@pwslap01u.europe.root.pri>
 <CAKc7PVBhHFUWbMobAeDptgXmZ=S6RVsuNB7Qwsq555Srya_5qg@mail.gmail.com>
 <20161020103259.0b0fe556@pwslap01u.europe.root.pri>
 <CAKc7PVA_NYiawEb=D+dP_ZZC==TqLxnQ4YqFLzQQQUPYKzrhZA@mail.gmail.com>

On Thu, 20 Oct 2016 11:56:30 +0200
Sebastian Gniazdowski <sgniazdowski@gmail.com> wrote:
> On 20 October 2016 at 11:32, Peter Stephenson <p.stephenson@samsung.com> wrote:
> > On Thu, 20 Oct 2016 07:55:13 +0200
> > See if this helps (I think next is the key one to update):
> >
> > diff --git a/Src/pattern.c b/Src/pattern.c
> 
> Still segfaults in the same place, and Valgrind reports two 8-byte reads.

Hmm... well, what I've posted fixes the pointers at line 650 of
pattern.c

		for (; pscan; pscan = next) {
		    next = PATNEXT(pscan);

where they would have been wrong before, so if you're *still* seeing
problems after the change, you've found something else.

pws