From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18451 invoked by alias); 20 Oct 2016 10:52:29 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 39685 Received: (qmail 8410 invoked from network); 20 Oct 2016 10:52:29 -0000 X-Qmail-Scanner-Diagnostics: from mailout1.w1.samsung.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(210.118.77.11):SA:0(-0.3/5.0):. Processed in 0.480963 secs); 20 Oct 2016 10:52:29 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-0.3 required=5.0 tests=RP_MATCHES_RCVD autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: p.stephenson@samsung.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at samsung.com does not designate permitted sender hosts) X-AuditID: cbfec7f1-f79f46d0000008eb-26-58089f8be3f7 Date: Thu, 20 Oct 2016 11:42:16 +0100 From: Peter Stephenson To: Zsh hackers list Subject: Re: Cores almost on demand in patcompile() Message-id: <20161020114216.020eb53e@pwslap01u.europe.root.pri> In-reply-to: Organization: Samsung Cambridge Solution Centre X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu) MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHIsWRmVeSWpSXmKPExsWy7djPc7rd8zkiDDpWilkcbH7I5MDoserg B6YAxigum5TUnMyy1CJ9uwSujLlXXrEXtLNXdB3uYG9gvMzaxcjJISFgIjH9zkU2CFtM4sK9 9UA2F4eQwFJGiab7PVBOL5PEhV+NLDAdS1d2M0MkljFKTPl+mgXCmcYkcetJBzuEc4ZRYsa8 t1D9ZxklmqdfB+tnEVCVuLr9HBOIzSZgKDF102xGEFtEQEtix8mTYHFhAWOJqTc2gcV5Bewl Ju5fCxbnFAiW2PjqJjuIzS+gL3H17ycmiJvsJWZeOQNVLyjxY/I9sF3MAjoS27Y9Zoew5SU2 r3kLdreEwH82icc3/gE1cAA5shKbDjBDzHGRWL1+NyOELSzx6vgWdghbRqKz4yDUrn5GiSfd vhBzZjBKnD6zAxp81hJ9ty8yQizjk5i0bTozxHxeiY42IYgSD4nP805Dw9FR4kTjJ6YJjIqz kJw9C8nZs5CcvYCReRWjSGppcW56arGRXnFibnFpXrpecn7uJkZgKjj97/jHHYzvT1gdYhTg YFTi4c04xx4hxJpYVlyZe4hRgoNZSYT3/WyOCCHelMTKqtSi/Pii0pzU4kOM0hwsSuK8exZc CRcSSE8sSc1OTS1ILYLJMnFwSjUwXjKNu9WpvmavklJXgFBSOWPhuyXHDx2zy9E6pDzX+bT7 mfuvBa4WHLn8dKLhljuqx2QPn1CWU11Q4LNIy7XoxuStarYpkz+7rJmuf9Tnl+1mtms+zexF z269l2dYzapXltwwp+GgT0HfY8em603vvk/Tt+Jl4rab52SR8vfPvjuyl9hEjnjOVWIpzkg0 1GIuKk4EADPSz08BAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrOIsWRmVeSWpSXmKPExsVy+t/xy7pV8zkiDLofalocbH7I5MDoserg B6YAxig3m4zUxJTUIoXUvOT8lMy8dFul0BA3XQslhbzE3FRbpQhd35AgJYWyxJxSIM/IAA04 OAe4Byvp2yW4Zcy98oq9oJ29outwB3sD42XWLkZODgkBE4mlK7uZIWwxiQv31rN1MXJxCAks YZS4cesLE4Qzg0ni3+fTrBDOOUaJK8+3Q5WdZZSY8ngdO0g/i4CqxNXt55hAbDYBQ4mpm2Yz gtgiAloSO06eBIsLCxhLTL2xCSzOK2AvMXH/WrA4p0CwxPdj3xkhhm5jl7j57jEbSIJfQF/i 6t9PTBAH2kvMvHIGqllQ4sfkeywgNjPQgs3bmlghbHmJzWvegj0kJKAucePubvYJjMKzkLTM QtIyC0nLAkbmVYwiqaXFuem5xYZ6xYm5xaV56XrJ+bmbGIGRtO3Yz807GC9tDD7EKMDBqMTD a9HKESHEmlhWXJl7iFGCg1lJhPf9bKAQb0piZVVqUX58UWlOavEhRlNgyExklhJNzgdGeV5J vKGJobmloZGxhYW5kZGSOG/JhyvhQgLpiSWp2ampBalFMH1MHJxSDYzJ91SuKDsfDBVqiXY4 kLt/2WT1fZtDgtJOi4k89nKxfjn3zseMQxfSDnWXTg8+57R0m++vY22dayqFos45lwbPDTob 4+pmtlht5s+drcVrjz3QUapy1f7noJhwYv2qhQzT1p5ao9bYvPCKdfC1Hhmvb5dm9pqel9Lf bCawdb7Ryz6xy76Bdt1KLMUZiYZazEXFiQBKtkc3ugIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20161020104218eucas1p2defa35dd31e66f50f00f9c0c5df2b3a7 X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?UGV0ZXIgU3RlcGhlbnNvbhtTQ1NDLURhdGEgUGxhbmUb?= =?UTF-8?B?7IK87ISx7KCE7J6QG1ByaW5jaXBhbCBFbmdpbmVlciwgU29mdHdhcmU=?= X-Global-Sender: =?UTF-8?B?UGV0ZXIgU3RlcGhlbnNvbhtTQ1NDLURhdGEgUGxhbmUbU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtQcmluY2lwYWwgRW5naW5lZXIsIFNvZnR3YXJl?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDA1Q0QwNTAwNTg=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20161011044403eucas1p1da8d4beef07f15ef1fb7e821eab83152 X-RootMTR: 20161011044403eucas1p1da8d4beef07f15ef1fb7e821eab83152 References: <20161013104321.29159e3f@pwslap01u.europe.root.pri> <20161019141435.42eb6df2@pwslap01u.europe.root.pri> <20161020103259.0b0fe556@pwslap01u.europe.root.pri> <20161020111819.4088896a@pwslap01u.europe.root.pri> On Thu, 20 Oct 2016 12:30:50 +0200 Sebastian Gniazdowski wrote: > Valgrind points at patadd(NULL, 0, nmeta, 0). Wonder why not to its > interior? But to all logic, problem should be inside patadd() because > nothing else near dereferences a pointer. So there might be two > problems. Debugger didn't report inaccessible memory when I did > step-over on the patadd(), maybe memory is accessible but invalid from > other reason recognized by Valgrind. Just to be sure, could you confirm the problem goes away if you change line 292 of pattern.c /* Default size for pattern buffer */ #define P_DEF_ALLOC 256 to /* Default size for pattern buffer */ #define P_DEF_ALLOC 512 ? That's not a fix, it's just putting off the problem, but if it's initially allocating something larger than what your pattern needs I'd expect the crash not to happen. pws