From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-39690-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 13603 invoked by alias); 20 Oct 2016 11:23:32 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 39690
Received: (qmail 9053 invoked from network); 20 Oct 2016 11:23:32 -0000
X-Qmail-Scanner-Diagnostics: from mailout2.w1.samsung.com by f.primenet.com.au (envelope-from <p.stephenson@samsung.com>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1.  
 Clear:RC:0(210.118.77.12):SA:0(-0.3/5.0):. 
 Processed in 0.421499 secs); 20 Oct 2016 11:23:32 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-0.3 required=5.0 tests=RP_MATCHES_RCVD
	autolearn=unavailable autolearn_force=no version=3.4.1
X-Envelope-From: p.stephenson@samsung.com
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
Received-SPF: none (ns1.primenet.com.au: domain at samsung.com does not designate permitted sender hosts)
X-AuditID: cbfec7f2-f79556d000002c42-41-5808a92af8f3
Date: Thu, 20 Oct 2016 12:23:18 +0100
From: Peter Stephenson <p.stephenson@samsung.com>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Cores almost on demand in patcompile()
Message-id: <20161020122318.136c6ae4@pwslap01u.europe.root.pri>
In-reply-to:
 <CAKc7PVChVhhSVbu1-6rvTjbz9rRjms2qjAaMe2ROFXWodA54qw@mail.gmail.com>
Organization: Samsung Cambridge Solution Centre
X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu)
MIME-version: 1.0
Content-type: text/plain; charset=US-ASCII
Content-transfer-encoding: 7bit
X-Brightmail-Tracker:
 H4sIAAAAAAAAA+NgFnrDIsWRmVeSWpSXmKPExsWy7djPc7paKzkiDLYe5bU42PyQyYHRY9XB
	D0wBjFFcNimpOZllqUX6dglcGad6ZzMV9LBW9O4vbmDsYOli5OSQEDCRmH7wGhOELSZx4d56
	ti5GLg4hgaWMEvtOH2cESQgJ9DJJLO7khGk4sGoTI0TRMkaJloXv2CGcaUwSU56fY4JwzgC1
	L5gKVXaWUeJLx3GwhSwCqhIX1m0Bm8smYCgxddNsMFtEQEtix8mTYIcICxhLTL2xCSzOK2Av
	0dV3C6yXUyBYYunFy2A1/AL6Elf/foI63F5i5pUzUPWCEj8m3wOrZxbQkdi27TE7hC0vsXnN
	W2aQgyQEfrNJzL4+ESjBAeTISmw6wAwxx0Xi0+OZ0IARlnh1fAs7hC0jcXlyN1S8n1HiSbcv
	xJwZjBKnz+xgg0hYS/TdvsgIsYxPYtK26cwQ83klOtqEIEo8JD7POw01x1HiROMnpgmMirOQ
	nD0LydmzkJy9gJF5FaNIamlxbnpqsbFecWJucWleul5yfu4mRmAaOP3v+KcdjF9PWB1iFOBg
	VOLhzTjHHiHEmlhWXJl7iFGCg1lJhDdqKUeEEG9KYmVValF+fFFpTmrxIUZpDhYlcd49C66E
	CwmkJ5akZqemFqQWwWSZODilGhhbH6+6mBKtP63hTdSS7D9yJnseVcyq1hfNq5NYOEXfcMa9
	t+lN+10LjK5v/up1KKZz6Y7quUJn3DuMGGdN2Djl6rVdMYc4dlfwNfxQFXZxWHn53dZoL+el
	qyZkfnPW/R/uvixVLT+Hb0nU40WtTmt2vTkWqFnAuoGHs/pf30qN1eeU0kqePspXYinOSDTU
	Yi4qTgQATsvUMP8CAAA=
X-Brightmail-Tracker:
 H4sIAAAAAAAAA+NgFlrKIsWRmVeSWpSXmKPExsVy+t/xa7qsKzkiDJZuU7M42PyQyYHRY9XB
	D0wBjFFuNhmpiSmpRQqpecn5KZl56bZKoSFuuhZKCnmJuam2ShG6viFBSgpliTmlQJ6RARpw
	cA5wD1bSt0twyzjVO5upoIe1ond/cQNjB0sXIyeHhICJxIFVmxghbDGJC/fWs3UxcnEICSxh
	lHi9aj47hDODSeLwlTtMEM45Ron+RXvBWoQEzjJKnDucA2KzCKhKXFi3BSzOJmAoMXXTbDBb
	REBLYsfJk0wgtrCAscTUGxDreAXsJbr6boGdwSkQLHFrCchJIAtOsUscXvmIGSTBL6AvcfXv
	JyaI++wlZl45A9UsKPFj8j2wZmagBZu3NbFC2PISm9e8ZYY4Tl3ixt3d7BMYhWchaZmFpGUW
	kpYFjMyrGEVSS4tz03OLjfSKE3OLS/PS9ZLzczcxAqNo27GfW3Ywdr0LPsQowMGoxMObcY49
	Qog1say4MvcQowQHs5IIb9RSjggh3pTEyqrUovz4otKc1OJDjKbAkJnILCWanA+M8LySeEMT
	Q3NLQyNjCwtzIyMlcd6pH66ECwmkJ5akZqemFqQWwfQxcXBKNTCejfCvW//135sX7yOjz6wQ
	9e+UKFzcIPbnQUe2uWrp7ujkMxNv90Qq9gpf0C8/rGG0hVN1gbzsBlPHM/NWxvp7fk/5W/rR
	4k3cpGjH5fsubBQNV2U8KHnxYNq2fMknYpuUDddbc3lIX2l/q/zgz4sbnPMu1dxWNXtivehf
	9LVZUSbKG69y2ukqsRRnJBpqMRcVJwIAdfaZ2LgCAAA=
X-MTR: 20000000000000000@CPGS
X-CMS-MailID: 20161020112321eucas1p22a00db778fbc8783478f3ad8aa0a088e
X-Msg-Generator: CA
X-Sender-IP: 182.198.249.180
X-Local-Sender: =?UTF-8?B?UGV0ZXIgU3RlcGhlbnNvbhtTQ1NDLURhdGEgUGxhbmUb?=
	=?UTF-8?B?7IK87ISx7KCE7J6QG1ByaW5jaXBhbCBFbmdpbmVlciwgU29mdHdhcmU=?=
X-Global-Sender: =?UTF-8?B?UGV0ZXIgU3RlcGhlbnNvbhtTQ1NDLURhdGEgUGxhbmUbU2Ft?=
	=?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtQcmluY2lwYWwgRW5naW5lZXIsIFNvZnR3YXJl?=
X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDA1Q0QwNTAwNTg=?=
CMS-TYPE: 201P
X-HopCount: 7
X-CMS-RootMailID: 20161011044403eucas1p1da8d4beef07f15ef1fb7e821eab83152
X-RootMTR: 20161011044403eucas1p1da8d4beef07f15ef1fb7e821eab83152
References:
 <CAKc7PVBEjPJMtV59CrN6LmrDaoGqfa_DZqwo3Y9HK=+0od7ycA@mail.gmail.com>
 <CGME20161011044403eucas1p1da8d4beef07f15ef1fb7e821eab83152@eucas1p1.samsung.com>
 <CAH+w=7a7jc0Q2=M9aG5mttbazxfsHB-Cz=WwJzCvz_SdnbApRw@mail.gmail.com>
 <20161013104321.29159e3f@pwslap01u.europe.root.pri>
 <CAKc7PVDcPxsm-kn4ReHybLAbCnk+0FrKP18Qp6s76jOf4trBew@mail.gmail.com>
 <20161019141435.42eb6df2@pwslap01u.europe.root.pri>
 <CAKc7PVBhHFUWbMobAeDptgXmZ=S6RVsuNB7Qwsq555Srya_5qg@mail.gmail.com>
 <20161020103259.0b0fe556@pwslap01u.europe.root.pri>
 <CAKc7PVA_NYiawEb=D+dP_ZZC==TqLxnQ4YqFLzQQQUPYKzrhZA@mail.gmail.com>
 <20161020111819.4088896a@pwslap01u.europe.root.pri>
 <CAKc7PVBWXcx5wa4yZA5O0Wa-AUjTc8eTpUBMaiuovD2Dz2hjnA@mail.gmail.com>
 <20161020114216.020eb53e@pwslap01u.europe.root.pri>
 <20161020115634.19683b37@pwslap01u.europe.root.pri>
 <20161020120319.1154c282@pwslap01u.europe.root.pri>
 <CAKc7PVChVhhSVbu1-6rvTjbz9rRjms2qjAaMe2ROFXWodA54qw@mail.gmail.com>

On Thu, 20 Oct 2016 13:09:25 +0200
Sebastian Gniazdowski <sgniazdowski@gmail.com> wrote:
> Tested the change, no segfault, also when break is added to unmodified
> code. Also checked if the pattern still matches (made use of the
> prepared input1.txt, input2.txt) and it does, in both versions.

Thanks.

I think that *is* the correct fix --- we add PAT_PURES to the flag that
will later be used when we run the pattern, and in that case any of the
usual wordcode infrastructure is irrelevant because we do indeed treat
it just as a single (metafied :-() string.  So breaking out of the loop
immediately is the right thing to do.

pws