From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-39729-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 23257 invoked by alias); 26 Oct 2016 11:06:12 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 39729
Received: (qmail 11552 invoked from network); 26 Oct 2016 11:06:12 -0000
X-Qmail-Scanner-Diagnostics: from out2-smtp.messagingengine.com by f.primenet.com.au (envelope-from <d.s@daniel.shahaf.name>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1.  
 Clear:RC:0(66.111.4.26):SA:0(0.0/5.0):. 
 Processed in 0.602484 secs); 26 Oct 2016 11:06:12 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=0.0 required=5.0 tests=T_DKIM_INVALID
	autolearn=unavailable autolearn_force=no version=3.4.1
X-Envelope-From: d.s@daniel.shahaf.name
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=
	daniel.shahaf.name; h=cc:content-type:date:from:in-reply-to
	:message-id:mime-version:references:subject:to:x-me-sender
	:x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=niT3PYiN9pzP3p8
	2aTiIpriR970=; b=jkTNbhLZI+lPCmcwaY3/feB+rrNB/y+MipIScgdyJX8BL82
	kXKCnzOwwAKSAnxGik9Qz8/oN+vpEp8yaZv53npBbmnhP98+TQLrjwyxwzDcJCfe
	TRSNw8ehQxyHiron+0J4lYLg3Qh2qfwh1n9mk/OhnOiYxe5A4X5TSgHFzPLY=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:content-type:date:from:in-reply-to
	:message-id:mime-version:references:subject:to:x-me-sender
	:x-me-sender:x-sasl-enc:x-sasl-enc; s=smtpout; bh=niT3PYiN9pzP3p
	82aTiIpriR970=; b=K/nRsVDXeQHJjBD9LuOk/zY16vGpjJ5w9WemuFS4bMcbhs
	WABp2ZmN8ylzTs+jSiabP+80gVdWeonYuEg8imti+6ueu/yM5COP7T+LjATO5tMJ
	uMgdDck8i0XcqkqsWexgvDnITDjBM0xOEhPHLJbj/MIYx4jsITJsS2Sh/R6Gw=
X-ME-Sender: <xms:bIwQWM_0ryofZILhsDCeNmLyXjWRJe5GiiEOrP6RSxg5cFX2qTU57w>
X-Sasl-enc: KseKqHI11UWcO6wTtRuTSIhDcHdz6gDMtDB0/BwxYnHu 1477479532
Date: Wed, 26 Oct 2016 10:56:52 +0000
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: "Jun T." <takimoto-j@kba.biglobe.ne.jp>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH} define _GNU_SOURCE on Cygwin
Message-ID: <20161026105652.GA14865@fujitsu.shahaf.local2>
References: <9E7FD5B2-061D-4ABE-84A8-A54C844E34BE@kba.biglobe.ne.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <9E7FD5B2-061D-4ABE-84A8-A54C844E34BE@kba.biglobe.ne.jp>
User-Agent: Mutt/1.5.23 (2014-03-12)

Jun T. wrote on Wed, Oct 26, 2016 at 19:04:08 +0900:
> Cygwin now started to require _XOPEN_SOURCE also for
> wcwidth() (in addition to strptime(); cf. worker/38862).
> 
> Since wcwidth() is used in may files, I think it would be
> better to define _GNU_SOURCE in zsh_system.h.
> 
> (defining _XOPEN_SOURCE alone hides may other function)

The patch causes _XOPEN_SOURCE to no longer be defined, ever.

Is this okay for both old and new cygwin?  I.e., does this patch work
for people compiling new zsh on old cygwin?