zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: "Peter A. Castro" <doctor@fruitbat.org>
Cc: "Jun T." <takimoto-j@kba.biglobe.ne.jp>, zsh-workers@zsh.org
Subject: Re: [PATCH} define _GNU_SOURCE on Cygwin
Date: Thu, 27 Oct 2016 01:34:38 +0000	[thread overview]
Message-ID: <20161027013438.GB15799@fujitsu.shahaf.local2> (raw)
In-Reply-To: <alpine.LNX.2.00.1610261248170.6490@ming.fruitbat.org>

Peter A. Castro wrote on Wed, Oct 26, 2016 at 12:55:36 -0700:
> On Wed, 26 Oct 2016, Jun T. wrote:
> >Unless someone still has older cygwin can test the patch, what we
> >can do would be to either go with _GNU_SOURCE (and to see whether
> >incompatibility with older cygwin comes out or not), or just
> >continue using the current code, which generates some warnings
> >but still seems to work fine (the return value of wcwidth() is int,
> >which is what compiler assumes when no prototype is available).
> 
> I'll see if I can give it a quick build and let you know.

Thanks, Peter.

I wasn't meaning to cause the two of you extra work; I had assumed
defining both _XOPEN_SOURCE and _GNU_SOURCE would work on both old and
new cygwin.  I.e., just adding _GNU_SOURCE without removing
_XOPEN_SOURCE.

Cheers,

Daniel


  reply	other threads:[~2016-10-27  1:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-26 10:04 Jun T.
2016-10-26 10:56 ` Daniel Shahaf
2016-10-26 12:30   ` Jun T.
2016-10-26 19:55     ` Peter A. Castro
2016-10-27  1:34       ` Daniel Shahaf [this message]
2016-10-31  6:15         ` Peter A. Castro
2016-11-01 12:11           ` Jun T.
2016-11-01 16:31             ` Peter A. Castro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161027013438.GB15799@fujitsu.shahaf.local2 \
    --to=d.s@daniel.shahaf.name \
    --cc=doctor@fruitbat.org \
    --cc=takimoto-j@kba.biglobe.ne.jp \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).