From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-39775-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 398 invoked by alias); 30 Oct 2016 15:57:45 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 39775
Received: (qmail 3473 invoked from network); 30 Oct 2016 15:57:45 -0000
X-Qmail-Scanner-Diagnostics: from out2-smtp.messagingengine.com by f.primenet.com.au (envelope-from <d.s@daniel.shahaf.name>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1.  
 Clear:RC:0(66.111.4.26):SA:0(0.0/5.0):. 
 Processed in 0.115064 secs); 30 Oct 2016 15:57:45 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=0.0 required=5.0 tests=T_DKIM_INVALID
	autolearn=unavailable autolearn_force=no version=3.4.1
X-Envelope-From: d.s@daniel.shahaf.name
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=
	daniel.shahaf.name; h=cc:content-type:date:from:in-reply-to
	:message-id:mime-version:references:subject:to:x-me-sender
	:x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=8yx1EWdjpaGlJG9
	dw/Rpr4ZzwSE=; b=WJ4hgDQkh2qNa6X0oWw97bhDLz5oSxjhrMbDOicKU4SpSS4
	NMYQmxmSqYUxQkC2PxFAnWdJQaHfRYCalByY0wSa8szMg93boOHqwo4HdUVGuvbj
	tCJLTDHE80bn2GLQSJscUGTo/SjkmeGDsZZSSgQcbtMC9bem4cXuOdQUNljM=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:content-type:date:from:in-reply-to
	:message-id:mime-version:references:subject:to:x-me-sender
	:x-me-sender:x-sasl-enc:x-sasl-enc; s=smtpout; bh=8yx1EWdjpaGlJG
	9dw/Rpr4ZzwSE=; b=H3swFCou/iTn0eV3Hw9g05bcy1ZTNEo32KRxx6CR/02Rg4
	iI9iqIJFCgRoZAsoT6aibkflqPVW0QmNM7OhfPmXiDZ/zzat6PyJxCg6F+pogdnR
	JTnecBwQyJlPGZ0OVVTednU22ExFN2RzI/KtMPMrFQReTor78ZHxJLdEhGztY=
X-ME-Sender: <xms:dhgWWO3rTzyWoBUDBwrIySCG-HUiLiVBePYVX1gL73zvqvR4tHpT1Q>
X-Sasl-enc: Bf3xcXm+ODte9gi53IaZzFQu0UwbGSGjFdh0IqaKKG65 1477843058
Date: Sun, 30 Oct 2016 15:55:30 +0000
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Frank Terbeck <ft@bewatermyfriend.org>
Cc: Reed Riley <john.reed.riley@gmail.com>, zsh-workers@zsh.org
Subject: Re: [PATCH] Fix hexdump command used for mercurial dirstate parsing
Message-ID: <20161030155530.GC12137@fujitsu.shahaf.local2>
References: <20161030024723.62832-1-john.reed.riley@gmail.com>
 <87y416drcq.fsf@ft.bewatermyfriend.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <87y416drcq.fsf@ft.bewatermyfriend.org>
User-Agent: Mutt/1.5.23 (2014-03-12)

Frank Terbeck wrote on Sun, Oct 30, 2016 at 12:11:01 +0100:
> "xxd" is a command shipped with vim. Adding such a dependency is out of
> the question for me.

That's my fault.  Reed's original patch used hexdump; I suggested to
just use xxd if hexdump gives trouble.

> It would be conceivable to make the command that is called in these
> places configurable via styles. But that is a separate issue to the
> one that fixes our use of hexdump.

Couldn't we replace hexdump by a pure zsh solution?  We simply need to
read 20 octets and print their hexadecimal values.

Cheers,

Daniel