From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10561 invoked by alias); 8 Nov 2016 10:02:08 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 39867 Received: (qmail 25823 invoked from network); 8 Nov 2016 10:02:08 -0000 X-Qmail-Scanner-Diagnostics: from mailout3.w1.samsung.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(210.118.77.13):SA:0(-2.8/5.0):. Processed in 0.479853 secs); 08 Nov 2016 10:02:08 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=RP_MATCHES_RCVD autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: p.stephenson@samsung.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at samsung.com does not designate permitted sender hosts) X-AuditID: cbfec7f4-f791c6d000006eac-33-5821a2901459 Date: Tue, 08 Nov 2016 10:01:49 +0000 From: Peter Stephenson To: zsh-workers@zsh.org Subject: Re: Compiler warning after workers/39825 Message-id: <20161108100149.6ad05be9@pwslap01u.europe.root.pri> In-reply-to: <1478589863.1742905.780812753.58D372CF@webmail.messagingengine.com> Organization: Samsung Cambridge Solution Centre X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu) MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrLIsWRmVeSWpSXmKPExsWy7djP87oTFilGGFxYomlxsPkhkwOjx6qD H5gCGKO4bFJSczLLUov07RK4MuZtuM1W8Jmj4t+0D+wNjD/Zuhg5OSQETCRaujYzQdhiEhfu rQeKc3EICSxllHi06zaU08sk8ePaOyaYjiuXvzNDJJYxSnzf9ZkdwpnGJHH7ylpGCOc0o8Sk o0tYIZwzjBJbX01mB+lnEVCV2PTrKiuIzSZgKDF102xGEFtEQFzi7NrzLCC2MFD8yuoPYPt4 Bewl7m6+BFbDKRAgMXXBO7BefgF9iat/P0HdZC8x88oZRoh6QYkfk++BzWEW0JHYtu0xO4Qt L7F5zVuwuyUE/rNJTJjWB9TMAeTISmw6wAwxx0Xizc4D0JARlnh1fAs7hC0jcXlyNwuE3c8o 8aTbF2LODEaJ02d2QDVYS/TdvsgIsYxPYtK26cwQ83klOtqEIEwPidubSyCqHSW6319hncCo OAvJ1bOQXD0LydULGJlXMYqklhbnpqcWm+gVJ+YWl+al6yXn525iBCaC0/+Of9nBuPiY1SFG AQ5GJR7eF/0KEUKsiWXFlbmHGCU4mJVEeCvnK0YI8aYkVlalFuXHF5XmpBYfYpTmYFES592z 4Eq4kEB6YklqdmpqQWoRTJaJg1OqgbG+j4l14euLCzOk/3/dr2i1WnR71bt3bhZs20R6AvhP yYmYvf17Ukch/RXHjrjE6l1MO3gb707+cuSf7BunlZ0TU/kXXGWbnXK870TT4qcSkYdzwvRF fdV/z/DIZDp3/MAGl8jPJ45f2ie9cNvXao8/f42Fv9tEK17eU+XlOkO+otlfbf3mn9OVWIoz Eg21mIuKEwEsLo7YAAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGIsWRmVeSWpSXmKPExsVy+t/xa7pFixQjDNauVrc42PyQyYHRY9XB D0wBjFFuNhmpiSmpRQqpecn5KZl56bZKoSFuuhZKCnmJuam2ShG6viFBSgpliTmlQJ6RARpw cA5wD1bSt0twy5i34TZbwWeOin/TPrA3MP5k62Lk5JAQMJG4cvk7M4QtJnHh3nqgOBeHkMAS Rom21oNQzgwmiXcvfzFCOKcZJd5+m80O0iIkcIZRYudqYxCbRUBVYtOvq6wgNpuAocTUTbMZ QWwRAXGJs2vPs4DYwkDxK6s/MIHYvAL2Enc3XwKr4RQIkJi64B0rxIKZTBKftk4DS/AL6Etc /fuJCeI+e4mZV84wQjQLSvyYfA9sKLOAlsTmbU2sELa8xOY1b5khjlOXuHF3N/sERuFZSFpm IWmZhaRlASPzKkaR1NLi3PTcYiO94sTc4tK8dL3k/NxNjMA42nbs55YdjF3vgg8xCnAwKvHw vuhXiBBiTSwrrsw9xCjBwawkwls5XzFCiDclsbIqtSg/vqg0J7X4EKMpMGQmMkuJJucDYzyv JN7QxNDc0tDI2MLC3MhISZx36ocr4UIC6YklqdmpqQWpRTB9TBycUg2M8aaKek8Oai3vfPko 5YnyBvdZK86qaIqbO74545VzRqUnKnd+TcXlnzv9+fjdO5f3HljQfI0j8ZZIXY5J/hc5Xclv ykcWvjp1xsC0O+StnGxy26eg/Dli7052a0ze1y90YgL/yV2f8nY33O9RrNm45liUdo1rhb7T 6pMCfnyP26UT24+bNmxSYinOSDTUYi4qTgQAz0RgLLkCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20161108100152eucas1p1773ebd6c2085df890262eb0083ee80b2 X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?UGV0ZXIgU3RlcGhlbnNvbhtTQ1NDLURhdGEgUGxhbmUb?= =?UTF-8?B?7IK87ISx7KCE7J6QG1ByaW5jaXBhbCBFbmdpbmVlciwgU29mdHdhcmU=?= X-Global-Sender: =?UTF-8?B?UGV0ZXIgU3RlcGhlbnNvbhtTQ1NDLURhdGEgUGxhbmUbU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtQcmluY2lwYWwgRW5naW5lZXIsIFNvZnR3YXJl?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDA1Q0QwNTAwNTg=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20161108072450epcas2p2a026529fbf8d08c49c153510d234e42d X-RootMTR: 20161108072450epcas2p2a026529fbf8d08c49c153510d234e42d References: <161107155001.ZM25685@torch.brasslantern.com> <1478588933.1740734.780806977.709688D0@webmail.messagingengine.com> <1478589863.1742905.780812753.58D372CF@webmail.messagingengine.com> On Mon, 07 Nov 2016 23:24:23 -0800 Sebastian Gniazdowski wrote: > Ah, the (mild) enlightenment is: char can be signed / unsigned. Wonder > if this can have any actual implications as 7f is AFAIK still in > unsigned range. For sure there are some techniques of solving such > portability problems hm Yes, that's it. We have a macro to perform a safe cast to unsigned. That's the right answer, since if the char is signed and is negative, it's *not* in a range we want to deal with. So the compiler was right... Casting 0x74 is unnecessary, since the constant will conform with unsigned char anyway, but I've made the point... pws diff --git a/Src/utils.c b/Src/utils.c index 733f570..d73110a 100644 --- a/Src/utils.c +++ b/Src/utils.c @@ -5341,7 +5341,7 @@ mb_metastrlenend(char *ptr, int width, char *eptr) inchar = *ptr; ptr++; - if (complete && (inchar >= 0 && inchar <= 0x7f)) { + if (complete && (inchar >= 0 && STOUC(inchar) <= STOUC(0x7f))) { /* * We rely on 7-bit US-ASCII as a subset, so skip * multibyte handling if we have such a character.