From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29848 invoked by alias); 8 Nov 2016 15:44:18 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 39873 Received: (qmail 4253 invoked from network); 8 Nov 2016 15:44:18 -0000 X-Qmail-Scanner-Diagnostics: from mailout4.w1.samsung.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(210.118.77.14):SA:0(-2.9/5.0):. Processed in 0.470349 secs); 08 Nov 2016 15:44:18 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=RP_MATCHES_RCVD autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: p.stephenson@samsung.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at samsung.com does not designate permitted sender hosts) X-AuditID: cbfec7f2-f79556d000002c42-f9-5821f2c90104 Date: Tue, 08 Nov 2016 15:44:06 +0000 From: Peter Stephenson To: zsh-workers@zsh.org Subject: Re: Compiler warning after workers/39825 Message-id: <20161108154406.6aab003e@pwslap01u.europe.root.pri> In-reply-to: <20161108153830.GA21983@fujitsu.shahaf.local2> Organization: Samsung Cambridge Solution Centre X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu) MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: quoted-printable X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrFIsWRmVeSWpSXmKPExsWy7djP87onPylGGNxcrG9xsPkhkwOjx6qD H5gCGKO4bFJSczLLUov07RK4MtZt+shasIa9YkuzXwPjSdYuRk4OCQETiaOz/zJC2GISF+6t Z+ti5OIQEljKKDFv708mCKeXSaLj4j2gKg6wjpUviiDiyxglNq48zAjhTGOSWPfsJZRzmlHi 89eTLBDOGUaJLy2nwZawCKhKND19zQRiswkYSkzdNBssLiIgLnF27XkWEFsYKH5l9QcmkHW8 AvYSv44IgYQ5Bawlmr90MoPY/AL6Elf/fmKCuNteYuaVM2BjeAUEJX5Mvgc2hllAU2Lr7vXs ELa2xJN3F1hB7pEQaGaXWN5yjR3iHVmJTQeYIea4SEz6cQQaLsISr45vYYewZSQuT+5mgbD7 GSWedPtCzJnBKHH6zA42iIS1RN/ti4wQy/gkJm2bzgwxn1eio00IwvSQuL25BKLaUaL7/RXW CYyKs5BcPQvJ1bOQXL2AkXkVo0hqaXFuemqxsV5xYm5xaV66XnJ+7iZGYAo4/e/4px2MX09Y HWIU4GBU4uHNeKgYIcSaWFZcmXuIUYKDWUmE1+cJUIg3JbGyKrUoP76oNCe1+BCjNAeLkjjv ngVXwoUE0hNLUrNTUwtSi2CyTBycUg2Mix/5PxMKnm/RXfJ/S+PEGultz7vZG+x/NC79b6/5 4M9V5izezCzjf3eCAyLuPjiePPnnfv9jvStuv+j6Hr/9368Pm9erH14WNvtUb7Gi8P+f4dcl VTJ3tkvtPLH0wobHu676L8oV71oUxCTkUrTr2l7u3k2nc5cffHQx4uyLHylxgY7BbtxP25RY ijMSDbWYi4oTAdgqgDz9AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrEIsWRmVeSWpSXmKPExsVy+t/xa7prPilGGDzdxWxxsPkhkwOjx6qD H5gCGKPcbDJSE1NSixRS85LzUzLz0m2VQkPcdC2UFPISc1NtlSJ0fUOClBTKEnNKgTwjAzTg 4BzgHqykb5fglrFu00fWgjXsFVua/RoYT7J2MXJwSAiYSKx8UdTFyAlkiklcuLeerYuRi0NI YAmjxKvrL5lBEkICM5gkXq8ogbBPM0pM3SsHUXSGUWLG69usIAkWAVWJpqevmUBsNgFDiamb ZjOC2CIC4hJn155nAbGFgeJXVn9gAlnMK2Av8euIEEiYU8BaovlLJzPEzG3MEvc/bQKr5xfQ l7j69xMTxHX2EjOvnAGbySsgKPFj8j2wGmYBdYlJ8xYxQ9jaEk/eXWCFOFRd4sbd3ewTGIVn IWmZhaRlFpKWBYzMqxhFUkuLc9Nzi430ihNzi0vz0vWS83M3MQLjZ9uxn1t2MHa9Cz7EKMDB qMTDm/FQMUKINbGsuDL3EKMEB7OSCK/PE6AQb0piZVVqUX58UWlOavEhRlNgwExklhJNzgfG dl5JvKGJobmloZGxhYW5kZGSOO/UD1fChQTSE0tSs1NTC1KLYPqYODilGhgdznTaXnL4evJ6 0IVHJssdVf3+fJsxJ8Tn7uxfW8Uvn4xQvDlzytGODC8Plyd2P5jVm9JfTKya9mOhkubsNVVq WXujpz/8bfo/U0An9Sz3460mKZsLHP8HXZpus2ZiV3D6AsYPuhNj5h7SPOu5JeODr0zdOdnM Dx/esSSJXX1ocSeD6Ut2c1S+EktxRqKhFnNRcSIAvxOrkrUCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20161108154409eucas1p18de0522687f36c1e7370f8119bc7c142 X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?UGV0ZXIgU3RlcGhlbnNvbhtTQ1NDLURhdGEgUGxhbmUb?= =?UTF-8?B?7IK87ISx7KCE7J6QG1ByaW5jaXBhbCBFbmdpbmVlciwgU29mdHdhcmU=?= X-Global-Sender: =?UTF-8?B?UGV0ZXIgU3RlcGhlbnNvbhtTQ1NDLURhdGEgUGxhbmUbU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtQcmluY2lwYWwgRW5naW5lZXIsIFNvZnR3YXJl?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDA1Q0QwNTAwNTg=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20161108072450epcas2p2a026529fbf8d08c49c153510d234e42d X-RootMTR: 20161108072450epcas2p2a026529fbf8d08c49c153510d234e42d References: <161107155001.ZM25685@torch.brasslantern.com> <1478588933.1740734.780806977.709688D0@webmail.messagingengine.com> <1478589863.1742905.780812753.58D372CF@webmail.messagingengine.com> <20161108100149.6ad05be9@pwslap01u.europe.root.pri> <20161108100735.0399368f@pwslap01u.europe.root.pri> <20161108153830.GA21983@fujitsu.shahaf.local2> On Tue, 8 Nov 2016 15:38:30 +0000 Daniel Shahaf wrote: > Peter Stephenson wrote on Tue, Nov 08, 2016 at 10:07:35 +0000: > > On Tue, 8 Nov 2016 10:01:49 +0000 > > Peter Stephenson wrote: > > > diff --git a/Src/utils.c b/Src/utils.c > > > index 733f570..d73110a 100644 > > > --- a/Src/utils.c > > > +++ b/Src/utils.c > > > @@ -5341,7 +5341,7 @@ mb_metastrlenend(char *ptr, int width, char *ep= tr) > > > inchar =3D *ptr; > > > ptr++; > > > =20 > > > - if (complete && (inchar >=3D 0 && inchar <=3D 0x7f)) { > > > + if (complete && (inchar >=3D 0 && STOUC(inchar) <=3D STOUC(0x7f))) { > > ^^^^^^^^^^^^ > >=20 > > This is now irrelevant, I'll remove that, too. >=20 > It's relevant on systems where the =C2=ABchar=C2=BB type is signed. No, read what the remaining modified test does. It's not using a signed value any more. pws