From: Peter Stephenson <p.stephenson@samsung.com>
To: zsh-workers@zsh.org
Cc: "Guillaume Maudoux (Layus)" <layus.on@gmail.com>
Subject: Re: [PATCH] make TERMINFO_DIRS variable special
Date: Wed, 09 Nov 2016 15:26:17 +0000 [thread overview]
Message-ID: <20161109152617.6eb4658c@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <bb5e3bb3-758b-2e32-86c3-144d06392d1e@gmail.com>
On Wed, 9 Nov 2016 15:47:10 +0100
"Guillaume Maudoux (Layus)" <layus.on@gmail.com> wrote:
> The general idea is that terminfo look for these varibales via getenv(),
> To pass them correctly, we need to export them to our own environment.
> The term update is just a nice extra feature avoiding the TERM=$TERM trick.
>
> I am not aware of the review/accept policy for patches.
> Could you tell me if this one has any chance to get merged ?
Can't see any problem generally, given it's exactly parellel to the
TERMINFO trick.
Usually you just need to post it (without the "> " and by any mechanism
that doesn't cause line wrap or other modifications) and wait for people
to comment.
One issue is that the doc implies (and people would probably expect)
that TERMINFO_DIRS is a tied variable with a terminfo_dirs array
equivalent. This doesn't exist. This would need accessors along the
lines of the contents of colonarr_gsu for the colon-separated version
and vararray_gsu for the array version. Possibly only the setters are
different.
pws
next prev parent reply other threads:[~2016-11-09 15:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <12935.1478707087@hydra.kiddle.eu>
2016-11-08 20:26 ` Guillaume Maudoux
2016-11-09 14:47 ` Guillaume Maudoux (Layus)
2016-11-09 15:26 ` Peter Stephenson [this message]
2016-11-09 15:35 ` Guillaume Maudoux (Layus)
2016-11-09 16:14 ` Guillaume Maudoux
2016-11-09 16:14 ` Guillaume Maudoux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161109152617.6eb4658c@pwslap01u.europe.root.pri \
--to=p.stephenson@samsung.com \
--cc=layus.on@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).