From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24819 invoked by alias); 13 Nov 2016 00:08:28 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 39930 Received: (qmail 15650 invoked from network); 13 Nov 2016 00:08:28 -0000 X-Qmail-Scanner-Diagnostics: from out4-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(66.111.4.28):SA:0(-0.7/5.0):. Processed in 3.09505 secs); 13 Nov 2016 00:08:28 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= daniel.shahaf.name; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= mesmtp; bh=TLi4dTLssBFa72XntMywvvRrJ7g=; b=h579NlbLeZ7Wwdrc9Vx3F rnVdta1WI3AfXUqFJFrZTcCLme4x5w1IgeRA6iF2qKDAhpCeqEQfYTJonZ6XEKlf +8DHOUMFZrr6l5M/lcUj/OufQvLdZ53RtH5Xz7RI/cyPNApzQwJoKm9T9Ze6jQoL uYr/zpIqkffei75+qGLmKM= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= smtpout; bh=TLi4dTLssBFa72XntMywvvRrJ7g=; b=QCi0o5hyMokNmkA1BcO2 gTvmyKtRK3e2UopnyCB824i9AQJv119llAI5u0VEqDm4X0tWCIQdhAD6sUsaluUV 2yWTfe3QgtIQgDuvEYsCUoPoVL2EDvZFmke/wtNAeBWWeM7LlHJtslXVFUZB3RfL 2adpEITjy31SRJigasDJQSk= X-ME-Sender: X-Sasl-enc: B+Qn4adnZUTo4s6y5RAagYjNrKVqPnihG80geW70mjoc 1478995700 Date: Sun, 13 Nov 2016 00:06:02 +0000 From: Daniel Shahaf To: zsh-workers@zsh.org Subject: Re: [PATCH] _git: Complete options and values for -c. Message-ID: <20161113000602.GA23271@fujitsu.shahaf.local2> References: <1478858354-8147-1-git-send-email-danielsh@fujitsu.shahaf.local2> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1478858354-8147-1-git-send-email-danielsh@fujitsu.shahaf.local2> User-Agent: Mutt/1.5.23 (2014-03-12) Daniel Shahaf wrote on Fri, Nov 11, 2016 at 09:59:14 +0000: > This bifurcates _git-config() in order to provide completion for > > % git -c > % git -c foo= Interdiff after feedback by Oliver: diff --git a/Completion/Unix/Command/_git b/Completion/Unix/Command/_git index 8e4b6e6..d5a3cfd 100644 --- a/Completion/Unix/Command/_git +++ b/Completion/Unix/Command/_git @@ -7527,9 +7527,14 @@ _git() { ;; (configuration) if compset -P 1 '*='; then - __git_config_value + __git_config_value && ret=0 else - __git_config_option -S = + if compset -S '=*'; then + __git_config_option + compstate[to_end]='' && ret=0 # don't move cursor if we completed just the "foo." in "foo.bar.baz=value" + else + __git_config_option -S '=' && ret=0 + fi fi ;; esac Known issue: completing «git -c user.em=foo» inserts "ail." (properly) but puts cursor to the right of the dot, rather than to its left.