From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27504 invoked by alias); 25 Nov 2016 17:01:51 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 40019 Received: (qmail 25261 invoked from network); 25 Nov 2016 17:01:51 -0000 X-Qmail-Scanner-Diagnostics: from out5-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(66.111.4.29):SA:0(-0.7/5.0):. Processed in 1.49244 secs); 25 Nov 2016 17:01:51 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= daniel.shahaf.name; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= mesmtp; bh=Ykwymam5cVAbN9MW3q1nfTqbjiY=; b=Metr/BTlNdkkitVJWtG1/ PdX1c0yjADZzanuZcSUsmKKQlaMMmWnY/m2TjkmcarWE85Fk2vrnuYqiZTNCocvi MaP5vR5Mi1kJ0YpTLKCd5AGPUewB4k6DlxY6YOWpU5Ql9WiXl5e964Ik265VTEhx StQwkmBrjfYkwTz6OudFC4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= smtpout; bh=Ykwymam5cVAbN9MW3q1nfTqbjiY=; b=KtfbjSRI22O9AnCwoDus DPSZg2lqCUFpWcQ82OAQzaRQjXmFpcia9Jz6P2to9JDVYzKwzG+QhQwQElqv8gdY qRHYwZZO8ny4EBsycKCvulBYS0AciPImsekm9mfyt5bXvO21Avescy9AB6bAqRW+ afxkTD7mqeD9lnaeNZO1wVo= X-ME-Sender: X-Sasl-enc: z7CFnYj2JJXks/KdGtUoCWZRBqVJXhy8Gbx1kuMSmGIE 1480093305 Date: Fri, 25 Nov 2016 16:59:13 +0000 From: Daniel Shahaf To: Laurent Arnoud Cc: zsh-workers@zsh.org Subject: Re: [PATCH] Add missing commands to Debian apt completion Message-ID: <20161125165913.GA10717@fujitsu.shahaf.local2> References: <20161122183137.uiqjriicn5g4fjwd@spk-laptop> <20161125093551.GA23516@fujitsu.shahaf.local2> <20161125161905.6jqtkq2arphofrat@spk-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20161125161905.6jqtkq2arphofrat@spk-laptop> User-Agent: Mutt/1.5.23 (2014-03-12) Laurent Arnoud wrote on Fri, Nov 25, 2016 at 17:19:05 +0100: > On Fri, Nov 25, 2016 at 09:35:51AM +0000, Daniel Shahaf wrote: > > Laurent Arnoud wrote on Tue, Nov 22, 2016 at 19:31:37 +0100: > > > +++ b/Completion/Debian/Command/_apt > > > @@ -402,17 +402,29 @@ _apt-cmd () { > > > /$'show\0'/ /$'[^\0]#\0'/ ':packages::_deb_packages "$expl_packages[@]" avail' \# \ > > > + /$'showsrc\0'/ /$'[^\0]#\0'/ ':packages::_deb_packages "$expl_packages[@]" avail' \# \| \ > > > > I had to move the 'showsrc' line to above the 'show' line for «apt > > showsrc » to work. Is this expected, or a bug in _apt_arguments > > or _regex_arguments? > > Yes you are right, I'm not sure about the bug but it is done like that in > `_apt-cache` function. I will just do as you did since I'm not an expert with > this. Actually, I looked again and a «\|» is missing from the 'list' and 'show' lines. I'll push your new patch with this modification. Thanks for the patch!