From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16350 invoked by alias); 29 Nov 2016 17:25:17 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 40043 Received: (qmail 15649 invoked from network); 29 Nov 2016 17:25:17 -0000 X-Qmail-Scanner-Diagnostics: from mailout2.w1.samsung.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(210.118.77.12):SA:0(-7.9/5.0):. Processed in 1.066381 secs); 29 Nov 2016 17:25:17 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-7.9 required=5.0 tests=RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: p.stephenson@samsung.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at samsung.com does not designate permitted sender hosts) X-AuditID: cbfec7f5-f79ce6d000004c54-3c-583db9f5d92e Date: Tue, 29 Nov 2016 17:25:06 +0000 From: Peter Stephenson To: Zsh Hackers' List Subject: Misaligned code? Message-id: <20161129172506.4e10dd78@pwslap01u.europe.root.pri> Organization: Samsung Cambridge Solution Centre X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu) MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: quoted-printable X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrFIsWRmVeSWpSXmKPExsWy7djPc7pfd9pGGPxq4rc42PyQyYHRY9XB D0wBjFFcNimpOZllqUX6dglcGU9/9rAXXOOuWDrnC1sD4zzOLkYODgkBE4m+2fldjJxAppjE hXvr2boYuTiEBJYySvxZ/xrK6WWS+HH4BRtElYnE6XcnmCESyxgl/t3dzALhTGOS+HvpCjuE c4ZRYvWp/VD9Zxklnu5/xwTSzyKgKvHz2BKwWWwChhJTN81mBDlEREBbov2jGIgpLCAp8WeC AkgFr4C9xM3Fm8Gq+QX0Ja7+/cQEcYW9xMwrZxghagQlfky+xwJiMwtoSmzdvZ4dwtaWePLu AivICRICr9kkdizqY4L4WVZi0wFmiDkuEtd7pkJ9Jizx6vgWdghbRqKz4yDUrn5GiSfdvhBz ZjBKnD6zA6rBWqLv9kVGiGV8EpO2TWeGmM8r0dEmBFHiIfF5TwsbRNhRYscNPpCwkECsxJOT 79gnMCrMQvLBLCQfzELywQJG5lWMIqmlxbnpqcWmesWJucWleel6yfm5mxiBKeD0v+NfdzAu PWZ1iFGAg1GJh/fFBNsIIdbEsuLK3EOMEhzMSiK8N7cAhXhTEiurUovy44tKc1KLDzFKc7Ao ifPuWXAlXEggPbEkNTs1tSC1CCbLxMEp1cCYtXOVGz/PdHcLvWshMRbMotKlhSaFM35Gbrw4 x+XkP3uHS4apzfJbehj/6Fz9YMm5UPtVVq+6c/JM8XlNXtXV75JDmw3OfuvLXff1PL/003mu ZT4vnwhmWlqXCm2Oer1YUndnZGiUy2dBPdkTj25E3L215r97mv6vHZen9y78u85a8/v6/TuU WIozEg21mIuKEwFMNowP/QIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuphkeLIzCtJLcpLzFFi42I5/e/4FV3WXbYRBud3ilocbH7I5MDoserg B6YAxig3m4zUxJTUIoXUvOT8lMy8dFul0BA3XQslhbzE3FRbpQhd35AgJYWyxJxSIM/IAA04 OAe4Byvp2yW4ZTz92cNecI27YumcL2wNjPM4uxg5OSQETCROvzvBDGGLSVy4t56ti5GLQ0hg CaPE388fmSCcGUwS8468Z4VwzjFKrF66jhnCOcso8WPpVRaQfhYBVYmfx5awgdhsAoYSUzfN Zuxi5OAQEdCWaP8oBmIKC0hK/JmgAFLBK2AvcXPxZrBqfgF9iat/PzFBXGEvMfPKGUaIGkGJ H5PvgU1nFlCXmDRvETOErS3x5N0FVhBbCCh+4+5u9gmMgrOQtMxC0jILScsCRuZVjCKppcW5 6bnFhnrFibnFpXnpesn5uZsYgTGx7djPzTsYL20MPsQowMGoxMM7oc82Qog1say4MvcQowQH s5II780tQCHelMTKqtSi/Pii0pzU4kOMpkDvT2SWEk3OB8ZrXkm8oYmhuaWhkbGFhbmRkZI4 b8mHK+FCAumJJanZqakFqUUwfUwcnFINjPwvvuxawp+n+Du6JPhn8MU15a82NCutP5b/MEj6 /vITrMZWUismzz/9ejObX6eqiIjm2Xvmf91lTM+va+SaefjiX8OC4FfLFybNdyvsv533hl0n 1X3mpZ1mvdu6Kyz6S/5dfTt7yxZethmVX2cW7p1wZ+Ue/qeKpsZFB1fIqAplaM1p8ml7d0aJ pTgj0VCLuag4EQC+YWeonwIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20161129172508eucas1p293f705922bdb6651cfcc762869b90740 X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?UGV0ZXIgU3RlcGhlbnNvbhtTQ1NDLURhdGEgUGxhbmUb?= =?UTF-8?B?7IK87ISx7KCE7J6QG1ByaW5jaXBhbCBFbmdpbmVlciwgU29mdHdhcmU=?= X-Global-Sender: =?UTF-8?B?UGV0ZXIgU3RlcGhlbnNvbhtTQ1NDLURhdGEgUGxhbmUbU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtQcmluY2lwYWwgRW5naW5lZXIsIFNvZnR3YXJl?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDA1Q0QwNTAwNTg=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20161129172508eucas1p293f705922bdb6651cfcc762869b90740 X-RootMTR: 20161129172508eucas1p293f705922bdb6651cfcc762869b90740 References: Is this just misaligned, as the warning says, or is there something else going on? I don't think it was just tab confusion, though there are tabs around. gcc -c -I. -I../../Src -I../../Src -I../../Src/Zle -I. -DHAVE_CONFIG_H -DM= ODULE -Wall -Wmissing-prototypes -ggdb -fPIC -o computil..o computil.c computil.c: In function =E2=80=98ca_get_opt=E2=80=99: computil.c:1698:6: warning: this =E2=80=98if=E2=80=99 clause does not guard= ... [-Wmisleading-indentation] if ((p->type =3D=3D CAO_OEQUAL || p->type =3D=3D CAO_EQUAL) && ^~ computil.c:1702:3: note: ...this statement, but the latter is misleadingly = indented as if it is guarded by the =E2=80=98if=E2=80=99 if (end) { ^~ pws diff --git a/Src/Zle/computil.c b/Src/Zle/computil.c index 0025dc3..c781673 100644 --- a/Src/Zle/computil.c +++ b/Src/Zle/computil.c @@ -1694,10 +1694,10 @@ ca_get_opt(Cadef d, char *line, int full, char **en= d) for (p =3D d->opts; p; p =3D p->next) if (p->active && ((!p->args || p->type =3D=3D CAO_NEXT) ? !strcmp(p->name, line) : strpfx(p->name, line))) { - int l =3D strlen(p->name); - if ((p->type =3D=3D CAO_OEQUAL || p->type =3D=3D CAO_EQUAL) && - line[l] && line[l] !=3D '=3D') - continue; + int l =3D strlen(p->name); + if ((p->type =3D=3D CAO_OEQUAL || p->type =3D=3D CAO_EQUAL) && + line[l] && line[l] !=3D '=3D') + continue; =20 if (end) { /* Return a pointer to the end of the option. */