zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.stephenson@samsung.com>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] add build-time option to use unicode9 character widths
Date: Wed, 30 Nov 2016 09:49:51 +0000	[thread overview]
Message-ID: <20161130094951.3a7e6530@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <161129115351.ZM27737@torch.brasslantern.com>

On Tue, 29 Nov 2016 11:53:51 -0800
Bart Schaefer <schaefer@brasslantern.com> wrote:
> On Nov 29,  5:21pm, Peter Stephenson wrote:
> } Subject: Re: [PATCH] add build-time option to use unicode9 character width
> }
> } On Tue, 29 Nov 2016 00:42:27 -0700
> } Joshua Rubin <joshua@rubixconsulting.com> wrote:
> } > This patch adds support for unicode9 character widths.
> } 
> } Thanks, that looks unproblematic as it's specially enabled --- there
> } should be some other people who can try it out now it's in.
> 
> This is almost exactly what I was suggesting we should put in a module,
> except with all those large tables loaded from a run-time external file
> of some sort.

There's a way forward, anyway.

It's separately enabled for now which gives people who want it the
ability to use it.

If it migrates to a module, --enable-unicode9 can then force the module
to be linked and loaded at boot.  Loading from an external file is then
a separate job.  There currently isn't an obvious hook to how this gets
linked in from a module, and as Sebastian has discovered the character
analysis functions really need to be lightweight (though character width
isn't among the most performance sensitive, I wouldn't think).  Autoload
seems pointless for something like this.

pws

diff --git a/NEWS b/NEWS
index 433703a..7ac144b 100644
--- a/NEWS
+++ b/NEWS
@@ -7,6 +7,12 @@ Note also the list of incompatibilities in the README file.
 Changes from 5.2 to 5.3
 -----------------------
 
+It is possible to enable character width support for Unicode 9 by
+congiuring with `--enable-unicode9'; this compiles in some additional
+tables.  At some point this support may move into a module, in which
+case the configure option will be changed to cause the module to be
+permanently loaded.
+
 The new word modifier ':P' computes the physical path of the argument.
 It is different from the existing ':a' modifier which always resolves
 '/before/here/../after' to '/before/after', and differs from the


  reply	other threads:[~2016-11-30  9:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20161129080722epcas3p3b988ea1997082b500e96febcab712655@epcas3p3.samsung.com>
2016-11-29  7:42 ` Joshua Rubin
2016-11-29  7:42   ` Joshua Rubin
2016-11-30 10:49     ` Jun T.
2016-11-29 17:21   ` Peter Stephenson
2016-11-29 19:53     ` Bart Schaefer
2016-11-30  9:49       ` Peter Stephenson [this message]
2016-11-30  9:53         ` Mikael Magnusson
2016-11-30 10:27           ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161130094951.3a7e6530@pwslap01u.europe.root.pri \
    --to=p.stephenson@samsung.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).