From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6946 invoked by alias); 4 Dec 2016 17:08:11 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 40081 Received: (qmail 26184 invoked from network); 4 Dec 2016 17:08:11 -0000 X-Qmail-Scanner-Diagnostics: from know-smtprelay-omc-11.server.virginmedia.net by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(80.0.253.75):SA:0(-0.0/5.0):. Processed in 2.718242 secs); 04 Dec 2016 17:08:11 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: p.w.stephenson@ntlworld.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _smtprelay.virginmedia.com designates 80.0.253.75 as permitted sender) X-Originating-IP: [86.21.219.59] X-Spam: 0 X-Authority: v=2.1 cv=ZKcq4iPb c=1 sm=1 tr=0 a=utowdAHh8RITBM/6U1BPxA==:117 a=utowdAHh8RITBM/6U1BPxA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=kj9zAlcOel0A:10 a=sJHWTmtfAAAA:8 a=UuuiS8p-3Yra7G-mSkIA:9 a=CjuIK1q_8ugA:10 a=AWX4Y1BGLXNi7rUpKzJt:22 Date: Sun, 4 Dec 2016 17:08:02 +0000 From: Peter Stephenson To: zsh-workers@zsh.org Cc: Debian Zsh Maintainers Subject: Re: zsh 5.2-test-1 Message-ID: <20161204170802.7528c7e4@ntlworld.com> In-Reply-To: <20161204164217.GQ5130@sym.noone.org> References: <20161202203009.2eee2e4b@ntlworld.com> <20161204032558.GL5130@sym.noone.org> <20161204164217.GQ5130@sym.noone.org> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.28; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 4 Dec 2016 17:42:19 +0100 Axel Beckert wrote: > 14:34:54 Running test: interactive shell returns to top level on ${...?...} error > 14:34:54 --- /tmp/zsh.ztst.err.25583 2016-12-04 13:34:54.074183275 +0000 > 14:34:54 +++ /tmp/zsh.ztst.terr.25583 2016-12-04 13:34:54.078183275 +0000 > 14:34:54 @@ -1 +1 @@ > 14:34:54 -foo:1: 1: no arguments given > 14:34:54 +% > > % > > foo:1: 1: no arguments given > 14:34:54 Test ../../Test/D04parameter.ztst failed: error output differs from expected as shown above for: > 14:34:54 PROMPT="" $ZTST_testdir/../Src/zsh -fis <<<' > 14:34:54 unsetopt PROMPT_SP > 14:34:54 PS2="" PS3="" PS4="" RPS1="" RPS2="" > 14:34:54 foo() { > 14:34:54 print ${1:?no arguments given} > 14:34:54 print not reached > 14:34:54 } > 14:34:54 foo > 14:34:54 print reached > 14:34:54 ' > 14:34:54 Was testing: interactive shell returns to top level on ${...?...} error > 14:34:54 ../../Test/D04parameter.ztst: test failed. I would guess this is some I/O oddity --- buffering would be the most likely suspect. The output gets tested before the error stream, so evidently that's printed "reached" as expected. That's the only interactive test in that file. I see in a copule of similar tests in A02alias.ztst we've assigned 2>&1. In the W01history.ztst tests we're sending 2>/dev/null. But this is murky... pws diff --git a/Test/D04parameter.ztst b/Test/D04parameter.ztst index 834550c..87cd90d 100644 --- a/Test/D04parameter.ztst +++ b/Test/D04parameter.ztst @@ -98,6 +98,7 @@ PROMPT="" $ZTST_testdir/../Src/zsh -fis <<<' unsetopt PROMPT_SP PS2="" PS3="" PS4="" RPS1="" RPS2="" + exec 2>&1 foo() { print ${1:?no arguments given} print not reached @@ -106,7 +107,7 @@ print reached ' 0:interactive shell returns to top level on ${...?...} error -?foo:1: 1: no arguments given +>foo:1: 1: no arguments given >reached print ${set1:+word1} ${set1+word2} ${null1:+word3} ${null1+word4}