From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22309 invoked by alias); 4 Dec 2016 19:01:52 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 40086 Received: (qmail 26833 invoked from network); 4 Dec 2016 19:01:52 -0000 X-Qmail-Scanner-Diagnostics: from sym2.noone.org by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(178.63.92.236):SA:0(-2.9/5.0):. Processed in 1.884669 secs); 04 Dec 2016 19:01:52 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: abe@sym2.noone.org X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at sym2.noone.org does not designate permitted sender hosts) Date: Sun, 4 Dec 2016 20:01:42 +0100 From: Axel Beckert To: pkg-zsh-devel@lists.alioth.debian.org, zsh-workers@zsh.org Subject: Re: [Pkg-zsh-devel] zsh 5.2-test-1 Message-ID: <20161204190141.GS5130@sym.noone.org> Mail-Followup-To: pkg-zsh-devel@lists.alioth.debian.org, zsh-workers@zsh.org References: <20161202203009.2eee2e4b@ntlworld.com> <20161204032558.GL5130@sym.noone.org> <20161204164217.GQ5130@sym.noone.org> <20161204170802.7528c7e4@ntlworld.com> <161204091941.ZM22403@torch.brasslantern.com> <20161204173131.73286df9@ntlworld.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161204173131.73286df9@ntlworld.com> X-Operating-System: Linux 3.2.0-4-amd64 X-Machine: sym2 x86_64 X-Editor: GNU Emacs 23.4.1 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAAAAAC3mUtaAAAABGdBTUEAALGPC/xhBQAAADh0RVh0U29mdHdhcmUAWFYgVmVyc2lvbiAzLjEwYSAgUmV2OiAxMi8yOS85NCAoUE5HIHBhdGNoIDEuMindFS5JAAACGElEQVQ4jXXQMU8UYRDG8f8shNjdDH4AbpfGDjAWlKiJiZ0ajL1aGCvsNCbGaCGG1koLaztaTYz6ATy+gOyehYmF3MxVxgg3FnDsHcTpJr/M+8w7Rf6nCsaVTTDqxbg9hoOXmw83H71+Eyfg4E1d7/Z2fG9rGkZbTQiu+K+3U/C+76lmkvAhJuDndnoAiftou4V84okAGclop4U/jYACZDTxrYWP0gkxVfAm/W//GLZpxIzwIN0Hn8dw0B+IWkZmQmRsj2HfhwokEklHfNCCiQCRgAR7YyhQVRVTCKCzP4Y5zBBE0t0zY3Q8oQaBqqAMlVEcgVQd9706zGirAFium8HXumlMIeMwqQCInju+2+uB6MRENupdpMt8pRlHZyuAW0F+Mb6XSIVqtxjD+iVmVqqystLEzFTGT92YqRaXpNT5eTVjeJhbALPnrTxLUZUKZsgxcNm64hAOYisT/xhF+oKTGU5RegtC3Rt6eEDi/QnIevdTx9Md2EMmYBRmCQR1026FCGQQJJExsRUqgkMGaWSbwYLnoO4T6VgpbQbdELPMBAHWWrhYrcxXnYgAsatPWygkFCBD4K62MAsOTqA6szYRPpsu6e6Y8mPiVrBMNuGIMrgwBUu4p2DgG1Ownu6hpuTv7hScefHAzAC/yRRw5U5pALMbJ4AUALvHSZhxgHPXTsHcdWD1GadAHr9avP+c0wCr7263Df8ASLwXWHWs+KIAAAAHdElNRQfYBQEBODPr Organization: The Debian Project User-Agent: Mutt/1.5.21 (2010-09-15) Hi, Peter Stephenson wrote: > On Sun, 4 Dec 2016 09:19:41 -0800 > Bart Schaefer wrote: > > On Dec 4, 5:08pm, Peter Stephenson wrote: > > } Subject: Re: zsh 5.2-test-1 > > } > > } > 14:34:54 @@ -1 +1 @@ > > } > 14:34:54 -foo:1: 1: no arguments given > > } > 14:34:54 +% > > } > > > } > % > > } > > > } > foo:1: 1: no arguments given > > } > > } I would guess this is some I/O oddity > > > > Looks more to me as if PS1 is being restored despite the assignment to > > PROMPT, possibly because PS1 has been exported into the environment by > > the test harness? > > Oh, that "+" in the diff might refer to all the following lines, in > which case you're probably right. I think so, yes. > diff --git a/Test/D04parameter.ztst b/Test/D04parameter.ztst > index 834550c..9ae6d0b 100644 > --- a/Test/D04parameter.ztst > +++ b/Test/D04parameter.ztst > @@ -97,7 +97,8 @@ > > PROMPT="" $ZTST_testdir/../Src/zsh -fis <<<' > unsetopt PROMPT_SP > - PS2="" PS3="" PS4="" RPS1="" RPS2="" > + PS1="" PS2="" PS3="" PS4="" RPS1="" RPS2="" > + exec 2>&1 > foo() { > print ${1:?no arguments given} > print not reached > @@ -106,7 +107,7 @@ > print reached > ' > 0:interactive shell returns to top level on ${...?...} error > -?foo:1: 1: no arguments given > +*>*foo:1: 1: no arguments given > >reached > > print ${set1:+word1} ${set1+word2} ${null1:+word3} ${null1+word4} Thanks, tried it, but it still fails, just slightly different: http://jenkins.grml.org/view/Debian/job/zsh-binaries/architecture=amd64/264/console 19:47:50 ../../Test/D04parameter.ztst: starting. 19:47:50 Running test: Basic scalar parameter substitution 19:47:50 Test successful. 19:47:50 Running test: Basic array parameter substitution 19:47:50 Test successful. 19:47:50 Running test: Basic ksharray substitution 19:47:50 Test successful. 19:47:50 Running test: Basic shwordsplit option handling 19:47:50 Test successful. 19:47:50 Running test: $+... 19:47:50 Test successful. 19:47:50 Running test: $+... with arrays 19:47:50 Test successful. 19:47:50 Running test: ${...:-...} and ${...-...} 19:47:50 Test successful. 19:47:50 Running test: ${...:=...}, ${...::=...}, ${...=...} 19:47:50 Test successful. 19:47:50 Running test: ${#${(A)=array=word}} counts array elements 19:47:50 Test successful. 19:47:50 Running test: ${...:?...}, ${...?...} 19:47:50 Test successful. 19:47:50 Running test: interactive shell returns to top level on ${...?...} error 19:47:50 --- /tmp/zsh.ztst.out.5687 2016-12-04 18:47:50.125589610 +0000 19:47:50 +++ /tmp/zsh.ztst.tout.5687 2016-12-04 18:47:50.129589609 +0000 19:47:50 @@ -1 +1,2 @@ 19:47:50 +foo:1: 1: no arguments given 19:47:50 reached 19:47:50 Test ../../Test/D04parameter.ztst failed: output differs from expected as shown above for: 19:47:50 PROMPT="" $ZTST_testdir/../Src/zsh -fis <<<' 19:47:50 unsetopt PROMPT_SP 19:47:50 PS1="" PS2="" PS3="" PS4="" RPS1="" RPS2="" 19:47:50 exec 2>&1 19:47:50 foo() { 19:47:50 print ${1:?no arguments given} 19:47:50 print not reached 19:47:50 } 19:47:50 foo 19:47:50 print reached 19:47:50 ' 19:47:50 Error output: 19:47:50 % % 19:47:50 Was testing: interactive shell returns to top level on ${...?...} error 19:47:50 ../../Test/D04parameter.ztst: test failed. Regards, Axel -- ,''`. | Axel Beckert , http://people.debian.org/~abe/ : :' : | Debian Developer, ftp.ch.debian.org Admin `. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5 `- | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE