From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23815 invoked by alias); 7 Dec 2016 12:16:11 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 40117 Received: (qmail 7609 invoked from network); 7 Dec 2016 12:16:11 -0000 X-Qmail-Scanner-Diagnostics: from out2-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(66.111.4.26):SA:0(-0.7/5.0):. Processed in 1.45144 secs); 07 Dec 2016 12:16:11 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= daniel.shahaf.name; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= mesmtp; bh=44dT95iSzgN53hs+btyS2eqi2j4=; b=nnHaJYtwocljLcCNzmE5e Is4kS2oBpWNW1pjBP1uR3yDNGLunPI5y0g89vub7jb4PAhyEFJbvZ8j2+Pq0mrOk 7huyt1hjws72VwFt7bQb/Iy0GElEPTx/cTO4gtlUmx/AwP5gMXNadhHTl8XHqntd sKJ19oUPV3xnCv6D0AgWv4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= smtpout; bh=44dT95iSzgN53hs+btyS2eqi2j4=; b=ppzeFtpudNJvL8GqlVFa V6GyJ6KyH3Bfs/ul8n04sIlOYL37QC+ZX0R9dPCoMrzNAW1cShTbFGLyUVaOqxYZ TzuvKPJbH+R+4C2mEhbkreF4PdXmH6HJ6gdJcU6wteKcW3CJ00cjPWi0mYEvh52e mRAGwETzp6nI/zJKlZ21MjI= X-ME-Sender: X-Sasl-enc: 2SfsCii3iyFDJrhB621sNUzv0nTcWBSZR8tFbppkMnWb 1481112519 Date: Wed, 7 Dec 2016 12:08:35 +0000 From: Daniel Shahaf To: Eitan Adler Cc: Zsh hackers list Subject: Re: [patch] minor patch to remove duplicates Message-ID: <20161207120835.GA1828@fujitsu.shahaf.local2> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Eitan Adler wrote on Mon, Nov 28, 2016 at 22:53:24 -0800: > +++ b/Src/input.c > @@ -51,7 +51,7 @@ > * Note that the input string is itself used as the input buffer: it is not > * copied, nor is it every written back to, so using a constant string > * should work. Consequently, when passing areas of memory from the heap > - * it is necessary that that heap last as long as the operation of reading > + * it is necessary that the heap last as long as the operation of reading The patch changed the meaning of this sentence. Wasn't the sentence more accurate before the patch? (To be clear — the sentence was grammatical not only after but also before the patch.) > * the string. After the string is read, the stack should be popped with > * inpop(), which effectively flushes any unread input as well as restoring > * the previous input state. > +++ b/Doc/Zsh/compsys.yo > @@ -144,8 +144,8 @@ directory mentioned in the tt(fpath) parameter, and should be autoloaded > few utility functions, arrange for all the necessary shell functions to be > autoloaded, and will then re-define all widgets that do completion to use the > new system. If you use the tt(menu-select) widget, which is part of the > -tt(zsh/complist) module, you should make sure that that module is loaded > -before the call to tt(compinit) so that that widget is also > +tt(zsh/complist) module, you should make sure that the module is loaded > +before the call to tt(compinit) so that the widget is also > re-defined. If completion styles (see below) are set up to perform > expansion as well as completion by default, and the TAB key is bound to > tt(expand-or-complete), tt(compinit) will rebind it to tt(complete-word); Cheers, Daniel