zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: zsh-workers@zsh.org
Cc: Ray Andrews <rayandrews@eastlink.ca>
Subject: Re: zsh-5.2-test-3
Date: Sun, 11 Dec 2016 03:26:03 +0000	[thread overview]
Message-ID: <20161211032603.GA32254@fujitsu.shahaf.local2> (raw)
In-Reply-To: <161210190737.ZM11109@torch.brasslantern.com>

Bart Schaefer wrote on Sat, Dec 10, 2016 at 19:07:37 -0800:
> +++ b/Src/Zle/compmatch.c
> @@ -674,7 +674,7 @@ match_str(char *l, char *w, Brinfo *bpp, int bc, int *rwlp,
>  		     *
>  		     * operation.  Similar to savw.
>  		     */
> -		    char savl;
> +		    char savl = 0;

I see you've pushed this, but for what it's worth, it wouldn't have been
my first choice.  I'd rather have left the variable uninitialized in the
(sfx is false) case, precisely so reading savl without checking sfx
first would result in an "is used uninitialized" warning.


  reply	other threads:[~2016-12-11  3:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20161206195028epcas2p3c53119ab37952571be3238cdf228d88f@epcas2p3.samsung.com>
     [not found] ` <20161206194916.10448440@ntlworld.com>
2016-12-06 23:33   ` test failures on Solaris (was Re: zsh-5.2-test-2) Danek Duvall
2016-12-07  0:36     ` Bart Schaefer
     [not found]   ` <20161209095729.2033b5be@pwslap01u.europe.root.pri>
     [not found]     ` <20161209195457.27e43234@ntlworld.com>
     [not found]       ` <584CB4EF.6070904@eastlink.ca>
2016-12-11  3:07         ` zsh-5.2-test-3 Bart Schaefer
2016-12-11  3:26           ` Daniel Shahaf [this message]
2016-12-11  3:33             ` zsh-5.2-test-3 Bart Schaefer
2016-12-11  3:26           ` zsh-5.2-test-3 Ray Andrews
2016-12-11  3:44             ` zsh-5.2-test-3 Bart Schaefer
2016-12-11  3:59               ` zsh-5.2-test-3 Ray Andrews
2016-12-11  9:36                 ` zsh-5.2-test-3 Bart Schaefer
2016-12-11 17:01                   ` zsh-5.2-test-3 Ray Andrews
2016-12-11 17:14                     ` zsh-5.2-test-3 Bart Schaefer
2016-12-11  4:11               ` zsh-5.2-test-3 Daniel Shahaf
2016-12-11  8:58                 ` zsh-5.2-test-3 Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161211032603.GA32254@fujitsu.shahaf.local2 \
    --to=d.s@daniel.shahaf.name \
    --cc=rayandrews@eastlink.ca \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).