From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-40145-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 25476 invoked by alias); 11 Dec 2016 03:28:57 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 40145
Received: (qmail 17773 invoked from network); 11 Dec 2016 03:28:57 -0000
X-Qmail-Scanner-Diagnostics: from out4-smtp.messagingengine.com by f.primenet.com.au (envelope-from <d.s@daniel.shahaf.name>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1.  
 Clear:RC:0(66.111.4.28):SA:0(-0.7/5.0):. 
 Processed in 1.253309 secs); 11 Dec 2016 03:28:57 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,
	RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,T_DKIM_INVALID autolearn=unavailable
	autolearn_force=no version=3.4.1
X-Envelope-From: d.s@daniel.shahaf.name
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=
	daniel.shahaf.name; h=cc:content-type:date:from:in-reply-to
	:message-id:mime-version:references:subject:to:x-me-sender
	:x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=lQMuCZjdeZ/sBSL
	6I3TT8zLvpIE=; b=XRwUUCQHUB4kKT5RvOry5gn8c+ajzZNy0wbblKo2oQ5Q1nr
	MvoiITIHuNCESMIpdaulzJ2eBEFWttANkjaI8cD09z5ek0xT5tg97W4tyIJW7aAy
	kewXQ+4d+uC3MakmUD2iKYqQFpyU4flgKLpZvDV85ozf9Et4CJFakOVC2P7A=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:content-type:date:from:in-reply-to
	:message-id:mime-version:references:subject:to:x-me-sender
	:x-me-sender:x-sasl-enc:x-sasl-enc; s=smtpout; bh=lQMuCZjdeZ/sBS
	L6I3TT8zLvpIE=; b=Crxs7Q92hKreQ5CRg8Zqy6qW746qPoE4/rUe/O7VkF7P3z
	k158+FMR2qgmjB6pua1wld506eUe6BvSZU+kihcyPHkkNZqoqkRUZaRBf8hwlxTu
	sQxtybJR9lznYDp8BWTsE8JpYyhn+C8uTeG5gJuQGqZjp9Nf1MjLHnGQALWN0=
X-ME-Sender: <xms:9cdMWKcdg8Gm3taC9cBzdPRq28y84LSSD42AiovPX8U-sb-PnWsbeA>
X-Sasl-enc: Ih1dxaABNFD62VOUGgweoPwx3kX2Eg+00gJ4ratIiQe9 1481426933
Date: Sun, 11 Dec 2016 03:26:03 +0000
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: zsh-workers@zsh.org
Cc: Ray Andrews <rayandrews@eastlink.ca>
Subject: Re: zsh-5.2-test-3
Message-ID: <20161211032603.GA32254@fujitsu.shahaf.local2>
References: <CGME20161206195028epcas2p3c53119ab37952571be3238cdf228d88f@epcas2p3.samsung.com>
 <20161206194916.10448440@ntlworld.com>
 <20161209095729.2033b5be@pwslap01u.europe.root.pri>
 <20161209195457.27e43234@ntlworld.com>
 <584CB4EF.6070904@eastlink.ca>
 <161210190737.ZM11109@torch.brasslantern.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <161210190737.ZM11109@torch.brasslantern.com>
User-Agent: Mutt/1.5.23 (2014-03-12)

Bart Schaefer wrote on Sat, Dec 10, 2016 at 19:07:37 -0800:
> +++ b/Src/Zle/compmatch.c
> @@ -674,7 +674,7 @@ match_str(char *l, char *w, Brinfo *bpp, int bc, int *rwlp,
>  		     *
>  		     * operation.  Similar to savw.
>  		     */
> -		    char savl;
> +		    char savl = 0;

I see you've pushed this, but for what it's worth, it wouldn't have been
my first choice.  I'd rather have left the variable uninitialized in the
(sfx is false) case, precisely so reading savl without checking sfx
first would result in an "is used uninitialized" warning.