From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: zsh-workers@zsh.org
Subject: Re: Error in zshaddhistory() should not prevent command from running
Date: Mon, 2 Jan 2017 02:48:00 +0000 [thread overview]
Message-ID: <20170102024800.GA3243@fujitsu.shahaf.local2> (raw)
In-Reply-To: <170101112030.ZM28010@torch.brasslantern.com>
Bart Schaefer wrote on Sun, Jan 01, 2017 at 11:20:30 -0800:
> On Jan 1, 3:10am, Daniel Shahaf wrote:
> } Subject: Re: Error in zshaddhistory() should not prevent command from runn
> }
> } > Possibly more controversial, why run this hook at all when nothing is
> } > being added?
> }
> } 2) It's easier to call the user-provided hook function on one more case
> } that it can easily ignore, than not to do so and to leave the user with
> } no easy alternative.
>
> As far as I can tell the only case where *chline == '\0' is when the EOF
> character has been typed -- there's always at least a newline in there
> in all other circumstances.
I'd assumed we were talking about empty lines (i.e., <accept-line> when
BUFFER=''). My bad. I don't have an opinion on whether zshaddhistory()
should be called during the EOF processing sequence.
> There are lots of other places to add to
> the history on shell exit. But this is why I asked -- other opinions?
>
next prev parent reply other threads:[~2017-01-02 3:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-31 6:13 Bart Schaefer
2017-01-01 3:10 ` Daniel Shahaf
2017-01-01 19:20 ` Bart Schaefer
2017-01-02 2:48 ` Daniel Shahaf [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-12-29 0:41 Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170102024800.GA3243@fujitsu.shahaf.local2 \
--to=d.s@daniel.shahaf.name \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).