From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3109 invoked by alias); 3 Jan 2017 14:26:57 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 40264 Received: (qmail 28588 invoked from network); 3 Jan 2017 14:26:57 -0000 X-Qmail-Scanner-Diagnostics: from out2-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(66.111.4.26):SA:0(-0.7/5.0):. Processed in 2.752236 secs); 03 Jan 2017 14:26:57 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= daniel.shahaf.name; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=DbfwI7XresCD1d4 I/HDp2o/KCtM=; b=qXFIo+Bkif92tqONUkNi6iEpTCfIb+pi0k/cLrkYNW1rEb8 /+NIhwHCSnhOdJxnBsTbqHiB2g3j+Ocsy6CSJIjACp0Km4skOzQoyL45XDWTLXu9 V0b5oX+nq6MomGuZbZ5nZsnU/merBbZuE2zoJCZR09s0YPUYq0Cuf4EE4grw= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=smtpout; bh=DbfwI7XresCD1d 4I/HDp2o/KCtM=; b=Z0FGWfqJRr0r0SXNYaxdfWb6W2FdZetc+DLM7uprxoU1kG nxyJiwO2Kb6J+lPdd0QiXZ1beRCC2j+MBRuK+qx770CEISPV0l5bQPgh00hsHu4z gNLVTWdLobIuV1hw2sGVm34EX75hr/8oy8x04h8fAkn+lsjoHyYJndZnDsmG4= X-ME-Sender: X-Sasl-enc: m2AZbTDqlMeM+fmHgv+1gos1THPuXXCamJQmva7pNgHY 1483453607 Date: Tue, 3 Jan 2017 14:23:36 +0000 From: Daniel Shahaf To: Benoit Izac Cc: zsh-workers@zsh.org Subject: Re: man completion breaks after upgrade from 5.2 to 5.3 Message-ID: <20170103142336.GA32586@fujitsu.shahaf.local2> References: <87o9zob681.fsf@izac.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87o9zob681.fsf@izac.org> User-Agent: Mutt/1.5.23 (2014-03-12) Benoit Izac wrote on Tue, Jan 03, 2017 at 14:53:02 +0100: > I have a problem with man completion since I upgraded 5.2 to 5.3, > man -a returns only a few possibilities (about 50) when man > returns about 23300 possibilities. > > I'm not comfortable with the zsh syntax used in completion, could > someone help me to find where it breaks? Bisected to: 896f43c72bcfd3f1e2240f54609868634a3c4e45 is the first bad commit commit 896f43c72bcfd3f1e2240f54609868634a3c4e45 Author: Daniel Shahaf Date: Thu Jan 14 15:37:43 2016 +0000 37634: _man: Support subsection names such as '3p'. Probably due to the "*${sect}*" change in there. This does the trick: diff --git a/Completion/Unix/Command/_man b/Completion/Unix/Command/_man index b2aaeaf..67810e1 100644 --- a/Completion/Unix/Command/_man +++ b/Completion/Unix/Command/_man @@ -51,7 +51,11 @@ _man() { sect="${sect//:/|}" sect="${sect//,/|}" elif (( CURRENT > 2 )); then - sect=$words[2] + case $words[2] in + (-a) sect='*';; + (-*) ;; + (*) sect=$words[2];; + esac fi if [[ $sect = (<->*|1M|l|n) || $sect = *\|* ]]; then -a means 'all sections' on Linux and FreeBSD, and this elif branch isn't used on Solaris. Does any other system have a conflicting/different meaning of -a? Cheers, Daniel (Thanks for the parallel IRC report, it was much faster to iterate that way)