From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14147 invoked by alias); 5 Jan 2017 04:16:39 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 40270 Received: (qmail 12036 invoked from network); 5 Jan 2017 04:16:38 -0000 X-Qmail-Scanner-Diagnostics: from out2-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(66.111.4.26):SA:0(-0.7/5.0):. Processed in 1.939933 secs); 05 Jan 2017 04:16:38 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= daniel.shahaf.name; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= mesmtp; bh=ls/+J1Lbf8+RAs8Sw0Mfo96+O6Y=; b=l+zu9nkkqo2O9aWNKgCJ7 hVtO50Y1puxRNL3G/aBDcfIuPLzmmlMRineZIngCfFzipc22KHJUwPhsQCcGT4Id A08pCYk/ZyEdW6kdZPTZurUujXBTOkp1NDe3tlm+HfjqaWTacelTTtE21nRsxRKv oMLEwDikL+0BE2OTBrszxk= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= smtpout; bh=ls/+J1Lbf8+RAs8Sw0Mfo96+O6Y=; b=n1l51jHr7l5dQjoJC01a m4dQgZXOA+CApOHYfe6IERBGhlKlLa0ffXtpoL1s8IoJmgYNYGE5QeQOsRvrxpSZ 9bqRZy/6FVCvDzGvHvEUEm7V2OGIWQFgI3r7vIvMazZ8MbjTFNOftC1T8E87WiN9 KpWU+VciwAHZe/xCksDN0bg= X-ME-Sender: X-Sasl-enc: tczBUyLP4vd6cgIkoH8Nj51uZ0HWVwGeIwHKg5Tm/gcU 1483589784 Date: Thu, 5 Jan 2017 04:13:11 +0000 From: Daniel Shahaf To: Sebastian Gniazdowski Cc: zsh-workers@zsh.org Subject: Re: Possible huge setarrvalue optimization Message-ID: <20170105041311.GA26507@fujitsu.shahaf.local2> References: <1479449829.1305485.791811385.14DDFE28@webmail.messagingengine.com> <1479461540.1340250.791913609.27FAD722@webmail.messagingengine.com> <1479471620.1371132.792049209.295BE093@webmail.messagingengine.com> <20161120114648.GA6953@fujitsu.shahaf.local2> <20161224171936.GA19748@fujitsu.shahaf.local2> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sebastian Gniazdowski wrote on Wed, Jan 04, 2017 at 13:31:52 -0500: > You then wrote: > > "Should this line check that «v->pm->gsu.a.setfn == arrsetfn»? > > Should this line check that «pm->ename == NULL» [since arrsetfn() > handles such arrays specially]?" > > I think both propositions are good, especially the ename check I've incorporated them when I pushed (4fb4ce190ccb). > – activated when parameter is being automatically exported – if I understand correctly. You could fix this by including code activated in the normal setter when ename is not null – like Peter did with string optimization. This way auto-exported arrays will still be optimized. [Peter's change to which you refer is 39995.] Thanks for the suggestion. I agree the pm->ename != NULL case could be optimised further, however, I don't intend to look into that myself. Here's also an addendum to 39995. diff --git a/Src/params.c b/Src/params.c index c64d748..fc313cd 100644 --- a/Src/params.c +++ b/Src/params.c @@ -3458,6 +3458,8 @@ strsetfn(Param pm, char *x) pm->node.flags |= PM_NAMEDDIR; adduserdir(pm->node.nam, x, 0, 0); } + /* If you update this function, you may need to update the + * `Implement remainder of strsetfn' block in assignstrvalue(). */ } /* Function to get value of an array parameter */ Thanks again for the review. Cheers, Daniel