From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24108 invoked by alias); 5 Jan 2017 15:50:39 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 40273 Received: (qmail 9545 invoked from network); 5 Jan 2017 15:50:39 -0000 X-Qmail-Scanner-Diagnostics: from out2-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(66.111.4.26):SA:0(-0.7/5.0):. Processed in 1.199323 secs); 05 Jan 2017 15:50:39 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= daniel.shahaf.name; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=wqYL6ZwY7pIqxlz pArXSdIZnxP0=; b=gyL7XKFTs6a7hgfW84s+ay5AfUBZFCLi3VRxAsb98sxUB9h hZDYsp2LnlgZA860+tEiJOHHHJRMlVd1R6IPqZLTtVC1+n36bmJQ//6NjlYZIa68 E8d4PD8oqPy5/quOyeymv6Vp7kO7Mblt+f8pN0OFDLZPI+fBkqzdjM+ZIk2Y= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=smtpout; bh=wqYL6ZwY7pIqxl zpArXSdIZnxP0=; b=DIhYy5b8X8atts+iS79DuelYHv/dMOwdOIk7vfOoTGtZCM qgn3cSU4MsaQSvJbTZNu/KBx9Hj5hjB335fOAgFbDwduGnsVGdTQl4VNbkhKg46i U+3yiUU99l2JxIkwgKBx6xLIH1kjtRLkdI2YX0kzB9cxW8Zp0SpwIWyymk5EU= X-ME-Sender: X-Sasl-enc: weigbv1GNZXSvKVm3yqMjCUQLXFUkvwtq0Ws1gCdt6sO 1483631432 Date: Thu, 5 Jan 2017 15:47:18 +0000 From: Daniel Shahaf To: Sebastian Gniazdowski Cc: zsh-workers@zsh.org Subject: Re: Possible huge setarrvalue optimization Message-ID: <20170105154718.GA8039@fujitsu.shahaf.local2> References: <1479449829.1305485.791811385.14DDFE28@webmail.messagingengine.com> <1479461540.1340250.791913609.27FAD722@webmail.messagingengine.com> <1479471620.1371132.792049209.295BE093@webmail.messagingengine.com> <20161120114648.GA6953@fujitsu.shahaf.local2> <20161224171936.GA19748@fujitsu.shahaf.local2> <20170105041311.GA26507@fujitsu.shahaf.local2> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sebastian Gniazdowski wrote on Thu, Jan 05, 2017 at 08:32:25 -0500: > Unless auto-exported parameters are marked as special (and it's rather > not the case), the point is that current code will miss environment > update on parameter update. Like I said, I added an 'ename == NULL' check when I pushed. The code in tip of master reads: if (pre_assignment_length == post_assignment_length && v->pm->gsu.a->setfn == arrsetfn /* ... and isn't something that arrsetfn() treats specially */ && 0 == (v->pm->node.flags & (PM_SPECIAL|PM_UNIQUE)) && NULL == v->pm->ename) Is that still wrong in some way?