From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3099 invoked by alias); 6 Jan 2017 16:52:53 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 40284 Received: (qmail 7256 invoked from network); 6 Jan 2017 16:52:53 -0000 X-Qmail-Scanner-Diagnostics: from out2-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(66.111.4.26):SA:0(-0.7/5.0):. Processed in 0.477321 secs); 06 Jan 2017 16:52:53 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= daniel.shahaf.name; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=eK3MQXv8obXUurO RodpBqpn32fQ=; b=jzvoyEMo00thKs2PR+cn7DAidloy/JYxUTFsI0105tBZ888 N2eUlS4FfL/DO2JQgxHYqycuU5xkjvGIPnzz48iCrAmdL+FE4I4P8gt2VB4uGmuU sMZpUsP+ELGP98XAO1jjzrmEiJfxb+pbjz0OhdVuGQLhP39PvnSLkYiVn0fk= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=smtpout; bh=eK3MQXv8obXUur ORodpBqpn32fQ=; b=ZM/ccw1nmgN58TuTrwthkkXrJnrQpXsJRGY8aaN0L/DyTJ Xiv9P58B2EcR5eE6EJngTkvFI0x8thiD+u71bN7Wmwn69wjPIuHmRsPmiQTreAJz wL0t9SJAOHfQwRV3oMl92wWF40pLeOZ1xLaCRmvbs43xvMLvgWdIeAdsSHeYg= X-ME-Sender: X-Sasl-enc: yjSjkKoCS1AumlhjchnBwfg7PZ3m+IPL6I86lBsJtN0A 1483721570 Date: Fri, 6 Jan 2017 16:49:30 +0000 From: Daniel Shahaf To: zsh-workers@zsh.org Subject: Re: vcs_info: '%' in payloads not escaped Message-ID: <20170106164930.GC4948@fujitsu.shahaf.local2> References: <20161227150507.GA20351@fujitsu.shahaf.local2> <20170105160730.GA21106@fujitsu.shahaf.local2> <170106075524.ZM7127@torch.brasslantern.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <170106075524.ZM7127@torch.brasslantern.com> User-Agent: Mutt/1.5.23 (2014-03-12) Bart Schaefer wrote on Fri, Jan 06, 2017 at 07:55:24 -0800: > On Jan 5, 4:07pm, Daniel Shahaf wrote: > } > } How about the following? > } > } [[[ > } @@ -131,12 +131,14 @@ VCS_INFO_git_handle_patches () { > } else > } git_applied_s="" > } fi > } + git_applied_s=${git_applied_s//'%'/%%} > } else > } git_applied_s=${hook_com[applied-string]} > } fi > > Shouldn't that + go above the "else"? No point in substituting on > git_applied_s when it has just been set to "" ? I was just future-proofing the code against potential future changes in the 'else' branch. See users/22290 ;-)