From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-40314-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 21891 invoked by alias); 9 Jan 2017 01:59:15 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 40314
Received: (qmail 29901 invoked from network); 9 Jan 2017 01:59:15 -0000
X-Qmail-Scanner-Diagnostics: from out1-smtp.messagingengine.com by f.primenet.com.au (envelope-from <d.s@daniel.shahaf.name>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1.  
 Clear:RC:0(66.111.4.25):SA:0(-0.7/5.0):. 
 Processed in 0.655919 secs); 09 Jan 2017 01:59:15 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,
	RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,T_DKIM_INVALID autolearn=unavailable
	autolearn_force=no version=3.4.1
X-Envelope-From: d.s@daniel.shahaf.name
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=
	daniel.shahaf.name; h=cc:content-type:date:from:in-reply-to
	:message-id:mime-version:references:subject:to:x-me-sender
	:x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=Pkoykdp7UxiZCpk
	Qlr81d7qGu+E=; b=p1nw8TS8iSemQ+ja0WT80TBDb2eEHsB1VRz9IxHW5stwitG
	vZwD0kYypGTElpGzJggy7dR9YSzfUnWpqpVs9VnfAOOHTb5Xt0JF+S9kifpFXqkz
	9uQZ2ZUkzHEEcH1b0qKi2SR2OSPlOeHb/Wc4YzhVrq6mboE7776bBE0KYcp8=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:content-type:date:from:in-reply-to
	:message-id:mime-version:references:subject:to:x-me-sender
	:x-me-sender:x-sasl-enc:x-sasl-enc; s=smtpout; bh=Pkoykdp7UxiZCp
	kQlr81d7qGu+E=; b=hjfJoFcK6FWMALA4/tKGo7OsYJTk65k3p3RIehlSVcKylu
	Q+NrMCovZTl40gQQVE/62ZaJEl8omMVrA70kAHvSlFzzDChDOWry8Nxb8lAqYuLE
	OE/Hm77NARplrk+bgaMKjMGw+8DOwecyDquCpfHH0VUlclRoWvHewCauqJcIM=
X-ME-Sender: <xms:b-5yWPjibFed-DdAYxr_64ec8F3CBQ-An1rt8r7BUZeVPQW1WAIPxA>
X-Sasl-enc: ArQJRCqmNJyebvscjMpXnMDoPc5AtJkairKPi3yLX2B9 1483927151
Date: Mon, 9 Jan 2017 01:55:53 +0000
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Peter Stephenson <p.w.stephenson@ntlworld.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Defining function based on alias
Message-ID: <20170109015553.GB25236@fujitsu.shahaf.local2>
References: <20170107221659.1b9232da@ntlworld.com>
 <20170108191922.3d3de59f@ntlworld.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20170108191922.3d3de59f@ntlworld.com>
User-Agent: Mutt/1.5.23 (2014-03-12)

Peter Stephenson wrote on Sun, Jan 08, 2017 at 19:19:22 +0000:
> +++ b/Src/input.c
> @@ -670,3 +670,22 @@ ingetptr(void)
>  {
>      return inbufptr;
>  }
> +
> +/**/
> +char *input_hasalias(void)

May we please have docstrings for new code?  E.g.,

/*
 * If the input at the top of the stack(?) is an alias, return the name of
 * that alias, otherwise return NULL.
 */

Gave this a quick spin with various aliases and global aliases; behaves
as I'd expect.

My main concern is that .zshrc files that contain such a bug will not be
sourced all the way through.  Add a README entry?

Thanks,

Daniel

> +{
> +    int flags = inbufflags;
> +    struct instacks *instackptr = instacktop;
> +
> +    for (;;)
> +    {
> +	if (!(flags & INP_CONT))
> +	    break;
> +	instackptr--;
> +	if (instackptr->alias)
> +	    return instackptr->alias->node.nam;
> +	flags = instackptr->flags;
> +    }
> +
> +    return NULL;
> +}