From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11907 invoked by alias); 12 Jan 2017 10:21:56 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 40334 Received: (qmail 8435 invoked from network); 12 Jan 2017 10:21:56 -0000 X-Qmail-Scanner-Diagnostics: from mailout1.w1.samsung.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(210.118.77.11):SA:0(-8.2/5.0):. Processed in 3.128009 secs); 12 Jan 2017 10:21:56 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-8.2 required=5.0 tests=RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: p.stephenson@samsung.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at samsung.com does not designate permitted sender hosts) X-AuditID: cbfec7f5-f79d06d000004445-ac-587758b67b18 Date: Thu, 12 Jan 2017 10:21:38 +0000 From: Peter Stephenson To: Jens Elkner , zsh-workers@zsh.org Subject: Re: fix watch implementation Message-id: <20170112102138.34f3e759@pwslap01u.europe.root.pri> In-reply-to: <20170112064644.GB10414@trex.cs.ovgu.de> Organization: Samsung Cambridge Solution Centre X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu) MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrOIsWRmVeSWpSXmKPExsWy7djP87rbIsojDJrPqli0Pl3MZHGw+SGT A5PHpxNqHqsOfmAKYIrisklJzcksSy3St0vgyri0eBJTwU72insNE9gaGBvZuhg5OSQETCSe 905jgrDFJC7cWw8U5+IQEljKKLGt6SgzhPOZUaJ1/3MmmI4pix6yQCSWMUr07dvIBOH8Y5To n7EcquUMo8Tkub9YIZyzjBL7voMM4+RgEVCV+HRhCdgsNgFDiambZjOC2CICThJPW+exgNjC QDVz3p0Di/MK2Et0PbzGDmJzCphK3P82E2wOv4C+xNW/n6BuspeYeeUMVL2gxI/J98DmMAvo SGzb9pgdwpaX2LzmLdh1EgLt7BK3fy8AcjiAHFmJTQeYIea4SEx69AJqprDEq+Nb2CFsGYnL k7tZIOx+Rokn3b4Qc2YwSpw+swMalNYSfbcvMkIs45OYtG061HxeiY42IYgSD4n29zcYIWxH iR1LHjJOYFScheTsWUjOnoXk7AWMzKsYRVJLi3PTU4tN9YoTc4tL89L1kvNzNzECk8Ppf8e/ 7mBceszqEKMAB6MSD+8Om7IIIdbEsuLK3EOMEhzMSiK8OqHlEUK8KYmVValF+fFFpTmpxYcY pTlYlMR59yy4Ei4kkJ5YkpqdmlqQWgSTZeLglGpg9DXKfhdrsPSs55sVHMfsNt269CpPwD95 uavdIqstTAWG/slyQRaS4RLuJ1jeNC9lmPCO9b7gpy+503gfiXjJbAhd3rSSyaDv8vQLXuka FxZ98xbxfHV29bbiqF+Hj+1i//BryglJ+ffHCuSycu52ndmgxVq19+fvldLtkmpRb++1tU/6 sedGlBJLcUaioRZzUXEiADEdErkKAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrPIsWRmVeSWpSXmKPExsVy+t/xy7rrIsojDG6fMrRofbqYyeJg80Mm ByaPTyfUPFYd/MAUwBTlZpORmpiSWqSQmpecn5KZl26rFBripmuhpJCXmJtqqxSh6xsSpKRQ lphTCuQZGaABB+cA92AlfbsEt4xLiycxFexkr7jXMIGtgbGRrYuRk0NCwERiyqKHLBC2mMSF e+uB4lwcQgJLGCU2NF5mBkkICTQwSXz/GASROMcoMXf6d1YI5yyjxMfWZkaQKhYBVYlPF5Yw gdhsAoYSUzfNBouLCDhJPG2dB7ZCGKhmzrtzYHFeAXuJrofX2EFsTgFTifvfZjJDDO1ilNg/ ZSNYEb+AvsTVv5+YIO6zl5h55QxUs6DEj8n3wIYyC2hJbN7WxAphy0tsXvMW6mx1iRt3d7NP YBSehaRlFpKWWUhaFjAyr2IUSS0tzk3PLTbSK07MLS7NS9dLzs/dxAiMrG3Hfm7Zwdj1LvgQ owAHoxIP7w6bsggh1sSy4srcQ4wSHMxKIrw6oeURQrwpiZVVqUX58UWlOanFhxhNgSEzkVlK NDkfGPV5JfGGJobmloZGxhYW5kZGSuK8Uz9cCRcSSE8sSc1OTS1ILYLpY+LglGpgzN4c/qO+ /qmcBJN18Mvvy19+T3Ex22SlOuPNjn5/JXH7rTlrFr0NTr6smn3r/psvnT/MZUIKg2b9VTwR 2uqu5sB62I89QPr6r+etbzNE5cM4DfcJXHYTyTtRt3TP5UaFw+UCclcqozbvmxjWL1K6fv+j Zf8fJYXZdUrPlTla7cGQZLVnlSaPEktxRqKhFnNRcSIAfjwGGMICAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170112102142eucas1p24068a2532a9b7d2114b7f96844ede020 X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?UGV0ZXIgU3RlcGhlbnNvbhtTQ1NDLURhdGEgUGxhbmUb?= =?UTF-8?B?7IK87ISx7KCE7J6QG1ByaW5jaXBhbCBFbmdpbmVlciwgU29mdHdhcmU=?= X-Global-Sender: =?UTF-8?B?UGV0ZXIgU3RlcGhlbnNvbhtTQ1NDLURhdGEgUGxhbmUbU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtQcmluY2lwYWwgRW5naW5lZXIsIFNvZnR3YXJl?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDA1Q0QwNTAwNTg=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170112064814epcas3p2f3bbccde5a0aa362e32b984f4150b0de X-RootMTR: 20170112064814epcas3p2f3bbccde5a0aa362e32b984f4150b0de References: <20170112064644.GB10414@trex.cs.ovgu.de> On Thu, 12 Jan 2017 07:46:44 +0100 Jens Elkner wrote: > when evaluating zsh as the new default shell for interactive use it was > discovered, that the 'watch' feature doesn't work on Solaris 11.3 and > Ubuntu 14.04, 15.04 and probably other modern platforms: 'log' never > shows anything and logins/logouts never show up. > > The attached patch fixes the implementation, has been successfully > tested on the platforms mentioned above (was developed against 5.0.7, > which is, what the vendors of the mentioned OS ship, however, someone on > irc reported, that it applies cleanly to the current master version as > well). Thanks, as it's all #ifdef'd for the appropriate cases and we're not stabilising the shell for a release at the moment I've just tweaked the formatting in minor ways and committed it. There may be some people around who can exercise it, but not many, by the sound of it. pws