From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18422 invoked by alias); 12 Jan 2017 16:12:50 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 40338 Received: (qmail 9243 invoked from network); 12 Jan 2017 16:12:50 -0000 X-Qmail-Scanner-Diagnostics: from out2-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(66.111.4.26):SA:0(-0.7/5.0):. Processed in 1.209128 secs); 12 Jan 2017 16:12:50 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= daniel.shahaf.name; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=kcwzJIrioHzH3/g WRdNEla4bFIc=; b=mEVDIJi/ooy+pYBK+22SZ/l1hZWxAcYB/BakXXcBVQLCmPK +jiEt1yYzjGwsNliHiNy6OUJX1N8uzItJdp+c++cbEfVhjMYIt0gRcdt0sM5PRVb /L4S3MNfe851eSHbuICQ4FdWBSC/lq03OTVnPwScRwh88nWwO4nkunpCZSH0= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=smtpout; bh=kcwzJIrioHzH3/ gWRdNEla4bFIc=; b=ITJuZOKjVeWPPZTl6zya7wNuy4XVY4n5yX/gpTyka8SUyj CnjM8bp5NPHOz7DiDAHExkolddcATACY9oNv9umSnaeFznKfFaV3xyMYH3yJCIiZ gXL7UtKtksRe/3Gu3Ne147j2IP53wrTVeE6eXEU/FuY+Arih5ybZyPGeofBYE= X-ME-Sender: X-Sasl-enc: JDGIOH018rRBjWlqlnO04Vr3ZYBo28d1r2SAQjvbb2DW 1484237566 Date: Thu, 12 Jan 2017 16:09:21 +0000 From: Daniel Shahaf To: Peter Stephenson Cc: Zsh Hackers' List Subject: Re: PATCH: autoload with explicit path Message-ID: <20170112160921.GA8048@fujitsu.shahaf.local2> References: <20170112125602.4fa64dc6@pwslap01u.europe.root.pri> <20170112154057.GA4899@fujitsu.shahaf.local2> <20170112155920.360ad5d7@pwslap01u.europe.root.pri> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170112155920.360ad5d7@pwslap01u.europe.root.pri> User-Agent: Mutt/1.5.23 (2014-03-12) Peter Stephenson wrote on Thu, Jan 12, 2017 at 15:59:20 +0000: > On Thu, 12 Jan 2017 15:40:57 +0000 > Daniel Shahaf wrote: > > We could also put these two members in a union{} if they are mutually > > exclusive (if at least one of them is NULL at all times). > > They are mutually exclusive, as one is only useful for an autoload and > one is only useful with real source, which is why it uses the same > pointer. Making it a union doesn't actually change anything: it's still > the same set of of reads and writes. Of course it would be exactly the same machine code, but the source code would be more robust against bugs. It's a lot harder to refer to the wrong union member than to use the ->filename member without testing PM_LOADDIR first.