From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26194 invoked by alias); 12 Jan 2017 16:27:07 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 40340 Received: (qmail 5763 invoked from network); 12 Jan 2017 16:27:07 -0000 X-Qmail-Scanner-Diagnostics: from out2-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(66.111.4.26):SA:0(-0.7/5.0):. Processed in 0.64454 secs); 12 Jan 2017 16:27:07 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= daniel.shahaf.name; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=l9cvTGqhpWrAjK1 x+PHZyagWdYA=; b=V0FoOZU5ZdADByuIFvL1UAdvEtwNdpUw1Lp2h26CXw+IGvY yXkEYgWufBkrnz9ULyiPIurGPzn7d0Gmht5HpIe2An6+2LAci5RB/72KbNj6CbtO yAS7jXy/zg0ryxD2oUeczEAAOubK2BzASoxSE2bxRo+dvPEjLttJGvKvVebc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=smtpout; bh=l9cvTGqhpWrAjK 1x+PHZyagWdYA=; b=MZdNKEU1jNdKA+ubTwZATtMw/H0bZ87KYymlU+K+2kKnd0 2Fqv6esUYPLf4XmD0tASeS/jsl8fvoy6TA+jbNN3iXTtF2d1QQYatlJ1SfhW/mMT M7LWpX49a+3SdRJFvCvSQUq1T9DLAcJ0W4QOVTnEhplR+SSypfs2paoE4Sc1U= X-ME-Sender: X-Sasl-enc: MDVt4DgXrdjpPyxwc5w/uksbUKJUf47RzlwAgUbxx39Y 1484238423 Date: Thu, 12 Jan 2017 16:23:38 +0000 From: Daniel Shahaf To: Peter Stephenson Cc: Zsh Hackers' List Subject: Re: PATCH: autoload with explicit path Message-ID: <20170112162338.GA8691@fujitsu.shahaf.local2> References: <20170112125602.4fa64dc6@pwslap01u.europe.root.pri> <20170112154057.GA4899@fujitsu.shahaf.local2> <20170112155920.360ad5d7@pwslap01u.europe.root.pri> <20170112160921.GA8048@fujitsu.shahaf.local2> <20170112161651.46865f31@pwslap01u.europe.root.pri> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170112161651.46865f31@pwslap01u.europe.root.pri> User-Agent: Mutt/1.5.23 (2014-03-12) Peter Stephenson wrote on Thu, Jan 12, 2017 at 16:16:51 +0000: > On Thu, 12 Jan 2017 16:09:21 +0000 > Daniel Shahaf wrote: > > Of course it would be exactly the same machine code, but the source code > > would be more robust against bugs. It's a lot harder to refer to the > > wrong union member than to use the ->filename member without testing > > PM_LOADDIR first. > > Hmm, feel free to write this if you think you can make things clearer; > the bit setting will tell you what needs doing in each case. But I > don't really see how it helps. If the bit happens to be set you will do > it one way having exactly the same effect as if you did it the other > way, so I don't see the gain. The point is that the next time writes: . foo(shf->filename); . that won't compile, so he will be forced to take into account the two distinct overloaded meanings. This might have prevented the bug you fixed in 40335 from being written. I'll see if adding it makes things clearer, will post if it does.