From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2435 invoked by alias); 12 Jan 2017 22:05:10 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 40343 Received: (qmail 29706 invoked from network); 12 Jan 2017 22:05:10 -0000 X-Qmail-Scanner-Diagnostics: from mail.cs.uni-magdeburg.de by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(141.44.21.48):SA:0(-3.2/5.0):. Processed in 1.167869 secs); 12 Jan 2017 22:05:10 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-3.2 required=5.0 tests=RP_MATCHES_RCVD autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: jel+zsh@cs.uni-magdeburg.de X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at cs.uni-magdeburg.de does not designate permitted sender hosts) X-Authentication-Warning: trex.cs.ovgu.de: elkner set sender to jel+zsh@cs.uni-magdeburg.de using -f Date: Thu, 12 Jan 2017 23:05:02 +0100 From: Jens Elkner To: zsh-workers@zsh.org Subject: Re: fix watch implementation Message-ID: <20170112220502.GA11170@trex.cs.ovgu.de> Mail-Followup-To: zsh-workers@zsh.org References: <20170112064644.GB10414@trex.cs.ovgu.de> <20170112102138.34f3e759@pwslap01u.europe.root.pri> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170112102138.34f3e759@pwslap01u.europe.root.pri> User-Agent: Mutt/1.5.21 (2010-09-15) X-Milter: milter4j - Mail Filter for Java 1.1.4 (b767) X-Milter: ClamAV 0.98.1-jel on mail - Status: Clean X-RcptTo: zsh-workers@zsh.org On Thu, Jan 12, 2017 at 10:21:38AM +0000, Peter Stephenson wrote: > On Thu, 12 Jan 2017 07:46:44 +0100 > Jens Elkner wrote: > > when evaluating zsh as the new default shell for interactive use it was > > discovered, that the 'watch' feature doesn't work on Solaris 11.3 and > > Ubuntu 14.04, 15.04 and probably other modern platforms: 'log' never > > shows anything and logins/logouts never show up. > > > > The attached patch fixes the implementation, has been successfully > > tested on the platforms mentioned above (was developed against 5.0.7, > > which is, what the vendors of the mentioned OS ship, however, someone on > > irc reported, that it applies cleanly to the current master version as > > well). > > Thanks, as it's all #ifdef'd for the appropriate cases and we're not > stabilising the shell for a release at the moment I've just tweaked the > formatting in minor ways and committed it. There may be some people > around who can exercise it, but not many, by the sound of it. OK, thanx! As long as the 'log' command shows something and this aligns with the output of the 'last' utility, everything should be fine. Regards, jel. -- Otto-von-Guericke University http://www.cs.uni-magdeburg.de/ Department of Computer Science Geb. 29 R 027, Universitaetsplatz 2 39106 Magdeburg, Germany Tel: +49 391 67 52768