From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28946 invoked by alias); 27 Jan 2017 09:42:13 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 40425 Received: (qmail 28891 invoked from network); 27 Jan 2017 09:42:13 -0000 X-Qmail-Scanner-Diagnostics: from mailout2.w1.samsung.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(210.118.77.12):SA:0(-8.2/5.0):. Processed in 3.859133 secs); 27 Jan 2017 09:42:13 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-8.2 required=5.0 tests=RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: p.stephenson@samsung.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at samsung.com does not designate permitted sender hosts) X-AuditID: cbfec7f2-f790f6d000002555-55-588b15e7619a Date: Fri, 27 Jan 2017 09:41:56 +0000 From: Peter Stephenson To: zsh workers Subject: Re: UTF-8 locales on BSDs do not support collation correctly Message-id: <20170127094156.44b31dfd@pwslap01u.europe.root.pri> In-reply-to: <20170126175717.0b5c87c1@pwslap01u.europe.root.pri> Organization: Samsung Cambridge Solution Centre X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu) MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHIsWRmVeSWpSXmKPExsWy7djPc7rPRbsjDJ53CFkcbH7I5MDoserg B6YAxigum5TUnMyy1CJ9uwSujM0TTrEWnOOpuL/6JWMDYzdXFyMnh4SAicSFu5dYIGwxiQv3 1rN1MXJxCAksZZR4tOMGM4TTyyRxYOMbFpiOX4/eskMkljFKzNrWBdUyjUni56dvUJkzjBId k3ZAZc4ySrxtnMMI0s8ioCoxdUcrK4jNJmAoMXXTbLC4CFC8+fs/sB3CAq4Sl1qPgdm8AvYS 27pamEBsTgEHiQd9LWwgNr+AvsTVv5+YIG6yl5h55QwjRL2gxI/J98B6mQV0JLZte8wOYctL bF7zFuwhCYHfbBKLb74BcjiAHFmJTQeYIea4SHxf1wo1U1ji1fEt7BC2jMTlyd1Q//czSjzp 9oWYM4NR4vSZHWwQCWuJvtsXGSGW8UlM2jYdaj6vREebEESJh0TH8j6oXY4S5yYcZJzAqDgL ydmzkJw9C8nZCxiZVzGKpJYW56anFhvrFSfmFpfmpesl5+duYgSmgtP/jn/awfj1hNUhRgEO RiUeXgbZrggh1sSy4srcQ4wSHMxKIrzVgt0RQrwpiZVVqUX58UWlOanFhxilOViUxHn3LLgS LiSQnliSmp2aWpBaBJNl4uCUamDUCndy5AkQnXizq3qNoXE8xy+TV1/3T7vr6qTj6x2hLNvL 8/KR/9QP6ifbQ7+WZMnuXvpMvkdLOvLeu921/6N9Z+SE3Hi4Vm7/109rZ62WnTwrzfcn7/HY xY/4ReMXt7XeLmkXY9FPOtKiai7tuiR9xorHKccvXjtfMGn5ZJsVpmlKK/ZMD56txFKckWio xVxUnAgAQgiuBwEDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrOIsWRmVeSWpSXmKPExsVy+t/xq7pPRLsjDKa3SFgcbH7I5MDoserg B6YAxig3m4zUxJTUIoXUvOT8lMy8dFul0BA3XQslhbzE3FRbpQhd35AgJYWyxJxSIM/IAA04 OAe4Byvp2yW4ZWyecIq14BxPxf3VLxkbGLu5uhg5OSQETCR+PXrLDmGLSVy4t56ti5GLQ0hg CaPEvDddrBDODCaJaU+PM0M45xgluicdgcqcZZTYd+I2WD+LgKrE1B2trCA2m4ChxNRNsxlB bBGgePP3fywgtrCAq8Sl1mNgNq+AvcS2rhYmEJtTwEHiQV8L1O6pTBJLe3+ADeIX0Je4+vcT E8SB9hIzr5xhhGgWlPgx+R7YIGYBLYnN25pYIWx5ic1r3jKD2EIC6hI37u5mn8AoPAtJyywk LbOQtCxgZF7FKJJaWpybnltspFecmFtcmpeul5yfu4kRGEnbjv3csoOx613wIUYBDkYlHt4I +a4IIdbEsuLK3EOMEhzMSiK81YLdEUK8KYmVValF+fFFpTmpxYcYTYEhM5FZSjQ5HxjleSXx hiaG5paGRsYWFuZGRkrivFM/XAkXEkhPLEnNTk0tSC2C6WPi4JRqYJSfdsjsAou6qH3E3AQr p+gtS/e+cXKf9DfNvGOj7DrGfWnrne9Yn+JqPxLKU8B9ZoPQwoMhz/mS/h95+43brWajq/ud T9+8vPfoZTAG7fjnvaBuul6JXd+Eiil/rkeFup05mi+s4agZMnvrU9ZvNezlF3w2WTsJrmVg Eyt3uLBjmwSX29IdO5VYijMSDbWYi4oTAe+Mr926AgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170127094158eucas1p16eb8289afba055d07c7d0066da4cb231 X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?UGV0ZXIgU3RlcGhlbnNvbhtTQ1NDLURhdGEgUGxhbmUb?= =?UTF-8?B?7IK87ISx7KCE7J6QG1ByaW5jaXBhbCBFbmdpbmVlciwgU29mdHdhcmU=?= X-Global-Sender: =?UTF-8?B?UGV0ZXIgU3RlcGhlbnNvbhtTQ1NDLURhdGEgUGxhbmUbU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtQcmluY2lwYWwgRW5naW5lZXIsIFNvZnR3YXJl?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDA1Q0QwNTAwNTg=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170125180232epcas5p16dff9be3a099a11458ad28a6eb2d2d92 X-RootMTR: 20170125180232epcas5p16dff9be3a099a11458ad28a6eb2d2d92 References: <20170126175717.0b5c87c1@pwslap01u.europe.root.pri> On Thu, 26 Jan 2017 17:57:17 +0000 Peter Stephenson wrote: > (I will supply a patch that checks for setutxent etc., now I've noticed > there aren't any yet, but that doesn't appear to be the problem here, > modulo obscurities.) Can't see any reason not to commit it anyway. Are there systems that use utmpx but getutent, not getutxent (which I think was the implication of the old code)? If so, we need the following; otherwise, we need the #ifdef higher up. pws diff --git a/Src/watch.c b/Src/watch.c index 7a6b930..6103ef1 100644 --- a/Src/watch.c +++ b/Src/watch.c @@ -87,9 +87,12 @@ #if !defined(WATCH_STRUCT_UTMP) && defined(HAVE_STRUCT_UTMPX) && defined(REAL_UTMPX_FILE) # define WATCH_STRUCT_UTMP struct utmpx -# define setutent setutxent -# define getutent getutxent -# define endutent endutxent +# if defined(HAVE_SETUTXENT) && defined(HAVE_GETUTXENT) && defined(HAVE_ENDUTXENT) +# define setutent setutxent +# define getutent getutxent +# define endutent endutxent +# endif + /* * In utmpx, the ut_name field is replaced by ut_user. * Howver, on some systems ut_name may already be defined this diff --git a/configure.ac b/configure.ac index dda52bc..c6ece67 100644 --- a/configure.ac +++ b/configure.ac @@ -1324,7 +1324,8 @@ AC_CHECK_FUNCS(strftime strptime mktime timelocal \ symlink getcwd \ cygwin_conv_path \ nanosleep \ - srand_deterministic) + srand_deterministic \ + setutxent getutxent endutxent) AC_FUNC_STRCOLL AH_TEMPLATE([REALPATH_ACCEPTS_NULL],