From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8303 invoked by alias); 28 Jan 2017 19:15:15 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 40441 Received: (qmail 20790 invoked from network); 28 Jan 2017 19:15:15 -0000 X-Qmail-Scanner-Diagnostics: from know-smtprelay-omc-7.server.virginmedia.net by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(80.0.253.71):SA:0(-1.2/5.0):. Processed in 0.691136 secs); 28 Jan 2017 19:15:15 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: p.w.stephenson@ntlworld.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _smtprelay.virginmedia.com designates 80.0.253.71 as permitted sender) X-Originating-IP: [86.21.219.59] X-Spam: 0 X-Authority: v=2.1 cv=SYcKDalu c=1 sm=1 tr=0 a=utowdAHh8RITBM/6U1BPxA==:117 a=utowdAHh8RITBM/6U1BPxA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=kj9zAlcOel0A:10 a=MWUjAzoEKyAA:10 a=q2GGsy2AAAAA:8 a=e3ujG8tM6AxCNdZcky8A:9 a=CjuIK1q_8ugA:10 a=z9dJwno5l634igLiVhy-:22 Date: Sat, 28 Jan 2017 19:15:11 +0000 From: Peter Stephenson To: zsh-workers@zsh.org Subject: Re: [PATCH] isearch: do not use PAT_STATIC since we call zle hooks Message-ID: <20170128191511.7de1b55e@ntlworld.com> In-Reply-To: References: <20170106172541.GA14113@fujitsu.shahaf.local2> <170108113358.ZM9462@torch.brasslantern.com> <20170108194021.18fb2011@ntlworld.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.28; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 28 Jan 2017 11:02:24 -0800 (PST) Bart Schaefer wrote: > So PAT_HEAPDUP is already there, it's just (not PAT_STATIC) ... and we > are back to deciding whether each individual use of PAT_STATIC is safe > WRT signals and hooks. > > Should we make it explicit anyway? > > diff --git a/Src/zsh.h b/Src/zsh.h > index d022260..c387414 100644 > --- a/Src/zsh.h > +++ b/Src/zsh.h > @@ -1531,6 +1531,7 @@ struct patstralloc { > > /* Flags used in pattern matchers (Patprog) and passed down to patcompile */ > > +#define PAT_HEAPDUP 0x0000 /* Dummy flag for default behavior */ It's ages since I looked at this. Yes, that's definitely clearer. pws