From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15794 invoked by alias); 28 Jan 2017 19:47:24 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 40444 Received: (qmail 10647 invoked from network); 28 Jan 2017 19:47:24 -0000 X-Qmail-Scanner-Diagnostics: from know-smtprelay-omc-7.server.virginmedia.net by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(80.0.253.71):SA:0(-1.2/5.0):. Processed in 1.149987 secs); 28 Jan 2017 19:47:24 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: p.w.stephenson@ntlworld.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _smtprelay.virginmedia.com designates 80.0.253.71 as permitted sender) X-Originating-IP: [86.21.219.59] X-Spam: 0 X-Authority: v=2.1 cv=SYcKDalu c=1 sm=1 tr=0 a=utowdAHh8RITBM/6U1BPxA==:117 a=utowdAHh8RITBM/6U1BPxA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=kj9zAlcOel0A:10 a=MWUjAzoEKyAA:10 a=q2GGsy2AAAAA:8 a=xVAkfMgXsklbEg_ZuGQA:9 a=CjuIK1q_8ugA:10 a=z9dJwno5l634igLiVhy-:22 Date: Sat, 28 Jan 2017 19:47:17 +0000 From: Peter Stephenson To: zsh-workers@zsh.org Subject: Re: [PATCH] isearch: do not use PAT_STATIC since we call zle hooks Message-ID: <20170128194717.00b4be7e@ntlworld.com> In-Reply-To: References: <20170106172541.GA14113@fujitsu.shahaf.local2> <170108113358.ZM9462@torch.brasslantern.com> <20170108194021.18fb2011@ntlworld.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.28; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 28 Jan 2017 11:39:02 -0800 (PST) Bart Schaefer wrote: > On Sat, 28 Jan 2017, Bart Schaefer wrote: > > > ... back to deciding whether each individual use of PAT_STATIC is safe > > WRT signals and hooks. > > Crimony, it looks like pretty much all of compctl.c is signal-UNsafe. > > All the functions are static[*] except for the zmodload entry points. > Would it be asking for trouble to wrap all the builtin and widget > implementations of compctl in queue_signals()/unqueue_signals()? Well, I think the definitive answer is probably the usual "who knows what anyone's doing with zsh features?" But my gut feel is compctl only ever got to the point that it was doing simple local stuff that finished quickly, and we're morally entitled to assume that anything that isn't like that is using compsys. So I'd be inclined to try what you suggest and just make sure a few simple builtin completions with compctl work. pws